Page MenuHome

UI: fix several labels and tooltips
ClosedPublic

Authored by Damien Picard (pioverfour) on Aug 2 2022, 10:42 PM.

Details

Summary
  • Properties > Physics > Soft Body > Edges
    • Use left-aligned column for Collision Edge and Face
    • Replace tooltip "View Layer" by "Spring Length"
  • Properties > Physics > Soft Body > Self Collision
    • Replace tooltip "Ball Size" by "Stiffness"
    • Replace tooltip "Ball Size" by "Dampening"
  • Properties > Physics > Fluid > Fluid > Gas > Fire
    • Replace label "Flame Color" by "Smoke Color"
  • Properties > Physics > Rigid Body > Surface Response > Bounciness
    • Replace tooltip "Restitution" by "Bounciness"
  • Properties > GP Visual Effects > Shadow
    • Replace tooltip "Offset of the shadow" by "Scale of the shadow"

The previous issues were reported in T43295.

  • "Color space used for images which contains non-color data (i.e. normal maps)"

-> "Color space used for images which contain non-color data (e.g. normal maps)"

  • "Use for sharp peaks ('JONSWAP', Pierson-Moskowitz method) with peak sharpening"

-> "Use for established oceans ('JONSWAP', Pierson-Moskowitz method) with peak sharpening"

  • "Proxy lost from object %s lib %s\n"

-> "Proxy lost from object %s lib %s\n"

  • "Proxy lost from object %s lib <NONE>\n"

-> "Proxy lost from object %s lib <NONE>\n"

  • "Add an collection info node to the current node editor"

-> "Add a collection..."

  • "Show the expanded in the user interface"

-> "Show the details in the user interface"

  • "Object Offset" (Grease Pencil array modifier)

-> "Object" (same as mesh modifier)
This is more consistent, and solves a conflict between the senses
"Uses Object Offset" and "Object by which to offset"

Diff Detail

Repository
rB Blender

Event Timeline

Damien Picard (pioverfour) requested review of this revision.Aug 2 2022, 10:42 PM
Damien Picard (pioverfour) created this revision.
Damien Picard (pioverfour) retitled this revision from UI: make several labels and tooltips more consistent to UI: fix several labels and tooltips.
Damien Picard (pioverfour) edited the summary of this revision. (Show Details)

Fix two more messages:

  • OCIO Non-Color color space: fix typos
  • Ocean modifier: replace "Use for sharp peaks..." by "Use for established oceans..."

@Julian Eisel (Severin) I assigned this to you as coordinator of the UI module, but maybe someone else could review this sort of patches as well?

Damien Picard (pioverfour) edited the summary of this revision. (Show Details)

Fix a few more issues

release/datafiles/colormanagement/config.ocio
174

Conjugation.

Normal maps are not the only instance of non-color data, only a single example of it. So “e.g” [for example, …] must be used instead of i.e. [that is, …].

release/scripts/startup/bl_ui/properties_physics_fluid.py
431

This actually describes the color of smoke, as shown by the default grey color and the tooltip, as well as the actual prop name:

RNA_def_property_ui_text(prop, "Smoke Color", "Color of smoke emitted from burning fuel");
release/scripts/startup/bl_ui/properties_physics_softbody.py
218–222

It’s unclear seeing “Face” on its own that it’s about face collisions, but a good solution to this is used consistently in the UI.
Before:

After:

source/blender/blenkernel/intern/object.cc
886

Two spaces?

892

Two spaces?

source/blender/editors/space_node/node_add.cc
625

An common copy/paste error
   ^-- Joke intended

source/blender/makesrna/intern/rna_camera.c
350

“Show the expanded” is not grammatically correct, this is probably a copy/paste error.

source/blender/makesrna/intern/rna_gpencil_modifier.c
2019

Object Offset is already the name of the boolean prop which activates object-based offsetting. There is no need to clarify that the object is for the offset, it’s very clear from the UI:

More importantly, this is an issue with translation because Object Offset can be translated either “[Do] offset by object” or “Object to use to offset”, and it’s easier and cleaner to fix the message than add a disambiguation.

Also, the equivalent modifier for non-GP objects uses “Object”, so it’s better to use the same name for consistency.

source/blender/makesrna/intern/rna_modifier.c
5597

Sharp peaks with peak sharpening sounds almost nonsensical.
Also, this item describes an established ocean, which isn’t mentioned in the tooltips. I believe the author made a mistake after copy and pasting from the previous item.

source/blender/makesrna/intern/rna_object_force.c
1967

This is a copy/paste error, the prop has nothing to do with the view layer.

2019

Copy/paste error.

2025

Copy/paste error

source/blender/makesrna/intern/rna_rigidbody.c
1156

This is the term used in the UI, so I think it makes sense to use the same name for the actual prop. It’s also much more obvious for non-physicists.

source/blender/makesrna/intern/rna_shader_fx.c
435

Copy/paste error.

Hans Goudey (HooglyBoogly) requested changes to this revision.Dec 8 2022, 6:45 PM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/makesrna/intern/rna_gpencil_modifier.c
2019

The property should be called "Offset Object" and the UI text should be overwritten in the modifier UI to be "Object".
The RNA property name should make sense by itself, since it doesn't have the context of the panel.

I'm not totally sure about this, but I think the boolean property can be called "Use Object Offset" in RNA, and just use the "Object Offset" text in the UI, where the context of the checkbox implies the "Use"

source/blender/makesrna/intern/rna_object_force.c
2025

I can't believe these copy & paste mistakes have lasted for so long!

This revision now requires changes to proceed.Dec 8 2022, 6:45 PM
Damien Picard (pioverfour) marked an inline comment as done.
  • Use "Use Object Offset" in RNA and "Object Offset" in the UI
  • Use "Offset Object" in RNA and "Object" in the UI

Thanks a lot for the review!

This revision is now accepted and ready to land.Dec 9 2022, 11:01 PM
This revision was automatically updated to reflect the committed changes.