Details

Reviewers

Commits

rB25237d262507: Attributes: Improve custom data initialization options

Summary

When allocating new CustomData layers, often we do redundant
initialization of arrays. For example, it's common that values are
allocated, set to their default value, and then set to some other
value. This is wasteful, and it negates the benefits of optimizations
to the allocator like D15082. There are two reasons for this. The
first is array-of-structs storage that makes it annoying to initialize
values manually, and the second is confusing options in the Custom Data
API. This patch addresses the latter.

The CustomData "alloc type" options are rearranged. Besides
the options that use existing layers, there are two remaining:

CD_SET_DEFAULT sets the default value.
- Usually zeroes, but for colors this is white (how it was before).
- Should be used when you add the layer but don't set all values.
CD_CONSTRUCT refers to the "default construct" C++ term.
- Only necessary or defined for non-trivial types like vertex groups.
- Doesn't do anything for trivial types like int or float3.
- Should be used every other time, when all values will be set.

The attribute API's AttributeInit types are updated as well.

The patch doesn't name any functional changes yet. Follow-up commits
will change code from CD_SET_DEFAULT to CD_CONSTRUCT where the
correctness is clear.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 4 2022, 4:54 AM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added inline comments.Aug 22 2022, 5:25 PM

source/blender/blenkernel/BKE_attribute.hh
86	Looks like this uses `CD_CONSTRUCT` internally, making the comment kind of wrong. Better not use "none" here.
source/blender/blenkernel/BKE_customdata.h
62	This could have a more specific comment that explains what happens with trivial types.
63	Should also have an integer value for consistency.
source/blender/blenkernel/intern/customdata.cc
155	Should specify that `data` is expected to be uninitialized, same below.

Improve naming and comments

Fix diff (forgot to save file)

Merge master

Jacques Lucke (JacquesLucke) requested changes to this revision.Aug 30 2022, 1:40 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/blenkernel/BKE_customdata.h
56	Mention that the default is zero for most types.
source/blender/io/wavefront_obj/tests/obj_importer_tests.cc
107	This looks unrelated and wrong.

This revision now requires changes to proceed.Aug 30 2022, 1:40 PM

Fix stray code from another branch
Improve comment

Jacques Lucke (JacquesLucke) accepted this revision.Aug 30 2022, 9:31 PM

This revision is now accepted and ready to land.Aug 30 2022, 9:31 PM

Closed by commit rB25237d262507: Attributes: Improve custom data initialization options (authored by Hans Goudey (HooglyBoogly)). · Explain WhyAug 30 2022, 9:58 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB25237d262507: Attributes: Improve custom data initialization options.

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Sep 5 2022, 8:28 PM

Attributes: Improve custom data initialization optionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54377

source/blender/blenkernel/BKE_attribute.hh

source/blender/blenkernel/BKE_customdata.h

source/blender/blenkernel/intern/DerivedMesh.cc

source/blender/blenkernel/intern/attribute.cc

source/blender/blenkernel/intern/attribute_access.cc

source/blender/blenkernel/intern/curves_geometry.cc

source/blender/blenkernel/intern/customdata.cc

source/blender/blenkernel/intern/data_transfer.c

source/blender/blenkernel/intern/deform.c

source/blender/blenkernel/intern/dynamicpaint.c

source/blender/blenkernel/intern/editmesh_tangent.c

source/blender/blenkernel/intern/geometry_component_curve.cc

source/blender/blenkernel/intern/mesh.cc

source/blender/blenkernel/intern/mesh_boolean_convert.cc

source/blender/blenkernel/intern/mesh_convert.cc

source/blender/blenkernel/intern/mesh_legacy_convert.cc

source/blender/blenkernel/intern/mesh_normals.cc

source/blender/blenkernel/intern/mesh_remap.c

source/blender/blenkernel/intern/mesh_remesh_voxel.cc

source/blender/blenkernel/intern/mesh_tangent.c

source/blender/blenkernel/intern/mesh_validate.cc

source/blender/blenkernel/intern/multires.c

source/blender/blenkernel/intern/multires_reshape.c

source/blender/blenkernel/intern/multires_reshape_subdivide.c

source/blender/blenkernel/intern/multires_unsubdivide.c

source/blender/blenkernel/intern/object.cc

source/blender/blenkernel/intern/object_deform.c

source/blender/blenkernel/intern/paint.c

source/blender/blenkernel/intern/particle_system.c

source/blender/blenkernel/intern/pointcloud.cc

source/blender/blenkernel/intern/subdiv_mesh.c

source/blender/blenkernel/intern/subsurf_ccg.c

source/blender/blenlib/intern/BLI_memarena.c

source/blender/blenloader/intern/versioning_legacy.c

source/blender/bmesh/intern/bmesh_construct.c

source/blender/bmesh/intern/bmesh_interp.c

source/blender/bmesh/intern/bmesh_mesh_convert.cc

source/blender/editors/curves/intern/curves_add.cc

source/blender/editors/mesh/mesh_data.cc

source/blender/editors/mesh/meshtools.cc

source/blender/editors/object/object_facemap_ops.c

source/blender/editors/object/object_modifier.cc

source/blender/editors/sculpt_paint/sculpt_dyntopo.c

source/blender/editors/sculpt_paint/sculpt_undo.c

source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp

source/blender/io/alembic/intern/abc_customdata.cc

source/blender/io/alembic/intern/abc_reader_mesh.cc

source/blender/io/collada/MeshImporter.cpp

source/blender/io/stl/importer/stl_import_mesh.cc

source/blender/io/usd/intern/usd_reader_mesh.cc

source/blender/io/wavefront_obj/importer/obj_import_mesh.cc

source/blender/io/wavefront_obj/tests/obj_importer_tests.cc

source/blender/makesrna/intern/rna_mesh.c

source/blender/makesrna/intern/rna_mesh_api.c

source/blender/modifiers/intern/MOD_cloth.c

source/blender/modifiers/intern/MOD_nodes.cc

source/blender/modifiers/intern/MOD_normal_edit.c

source/blender/modifiers/intern/MOD_ocean.c

source/blender/modifiers/intern/MOD_screw.c

source/blender/modifiers/intern/MOD_skin.c

source/blender/modifiers/intern/MOD_solidify_extrude.c

source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

source/blender/modifiers/intern/MOD_uvproject.c

source/blender/modifiers/intern/MOD_weighted_normal.c

source/blender/modifiers/intern/MOD_weightvgedit.c

source/blender/modifiers/intern/MOD_weightvgmix.c

source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc

Attributes: Improve custom data initialization options
ClosedPublic
Actions

Revision Contents
Changeset List