Page MenuHome

Fix T46078 Rework Smoke Materials
AbandonedPublic

Authored by Aaron Carlisle (Blendify) on Oct 17 2015, 3:34 AM.

Details

Summary

Fix T46078 Rework Smoke Materials. I also cleaned the BI volume page. i think this is the only image that is not included in the diff

Diff Detail

Repository
rBM Blender Manual

Event Timeline

Aaron Carlisle (Blendify) retitled this revision from to Fix T46078 Rework Smoke Materials.
Aaron Carlisle (Blendify) updated this object.
Aaron Carlisle (Blendify) set the repository for this revision to rBM Blender Manual.
Aaron Carlisle (Blendify) changed the edit policy from "All Users" to "Documentation (Project)".

Nice work!
This looks pretty good to me, but couldn't get the diff to apply properly here.. Are you able to apply it on your end?

And a minor nitpick, but I noticed a lot of phrasings sound rather "instructiony"; like "go here, select it, then give it this". Not a huge deal, but I feel it doesn't quite fit with the reference manual goal (sounds more tutorial-like to me).

It may because the images are empty. I will remove them from the patch and when the patch is committed I will remove and add the images

Kitt Zwovic (gandalf3) edited edge metadata.EditedOct 17 2015, 8:24 PM

It's still only partially applying to volume.rst
Are you creating the diff against an up-to-date working copy?

Yes, Im at 812

I tried to redo the patch from scratch. but still does not apply. But im successfully building my local repository.

It seams that non of my patch will apply. Something must be wrong with the .diff file. because my commits are fine so I will commit this when it is ready to be merged

Anything for the review?

It *looks* fine from what I can see in the diff, but I can't check for compile issues etc. without applying the diff.
Not too sure what's to be done in such situations.. If you can commit it okay then perhaps that will do