Details

Reviewers

Commits

rBbad55d56bc71: Mesh: Parallelize remesh reprojections
rB34009dfb2390: Parallelize remesh reprojects

Summary

In high poly meshes the reprojections after remesh can become slow.
This patch parallelizes the reprojection of face sets, paint mask and vertex paint.

Here are before/after timelines of remeshing a 3.4M poly mesh (in sculpt mode).

Before: 19.6s
After: 8.7s

Diff Detail

Repository: rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Aug 6 2022, 9:31 AM

Erik Abrahamsson (erik85) created this revision.

Harbormaster completed remote builds in B23283: Diff 54465.Aug 6 2022, 9:31 AM

Update grain size

Harbormaster completed remote builds in B23284: Diff 54466.Aug 6 2022, 9:34 AM

Erik Abrahamsson (erik85) retitled this revision from Parallelize remesh reprojects to Parallelize remesh reprojections.Aug 6 2022, 9:53 AM

Erik Abrahamsson (erik85) edited the summary of this revision. (Show Details)

Erik Abrahamsson (erik85) added a project: Modeling.

Bert Van den Bosch (Crumbled) awarded a token.Aug 6 2022, 10:10 AM

silex (silex) awarded a token.Aug 6 2022, 11:34 AM

Daniel Gryningstjerna (Dangry) awarded a token.Aug 6 2022, 7:32 PM

TheRedWaxPolice (TheRedWaxPolice) awarded a token.Aug 6 2022, 9:51 PM

TheRedWaxPolice (TheRedWaxPolice) added a subscriber: TheRedWaxPolice (TheRedWaxPolice).

Daniel Gryningstjerna (Dangry) added a subscriber: Daniel Gryningstjerna (Dangry).Aug 6 2022, 11:36 PM

Add PROP_NO_DEG_UPDATE to remesh props.
Exit early if source has no face sets

Harbormaster completed remote builds in B23285: Diff 54475.Aug 7 2022, 2:05 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2022, 7:49 PM

Closed by commit rB34009dfb2390: Parallelize remesh reprojects (authored by Erik Abrahamsson (erik85)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Erik Abrahamsson (erik85) added a commit: rB34009dfb2390: Parallelize remesh reprojects.

Erik Abrahamsson (erik85) added a reverting change: rB341e9f7a7c42: Revert "Parallelize remesh reprojects".Aug 7 2022, 8:11 PM

Reopening again as I accidentally pushed it and then reverted.

That's quite measurable speedup :)

Add PROP_NO_DEG_UPDATE to remesh props.

Did this get lost? or was it committed separately.

@Jacques Lucke (JacquesLucke) what.I am wondering is whether it is more readable to capture with [&] or woth [&bvhtree, &target_verts, &target_mask, &source_mask]. Do we have some guide w.r.t "capture explicitly"?
Also, shall the rather big lambda become a named predicator class?

@Sergey Sharybin (sergey) I don't think we have a general guideline for this yet. Currently my take on this is as follows:

When the lambda will only be called in the scope it is created in, use [&]. This is the case here.
In all other cases explicitly capture the variables by reference/copy. So don't use [=].

I probably wouldn't move the lambda to a separate function here. In practice I didn't find that this makes it easier for. Also, if that is done, it should probably be done separately since the patch is much simpler in its current form.

This revision is now accepted and ready to land.Sep 14 2022, 11:44 AM

In D15638#434025, @Sergey Sharybin (sergey) wrote:

That's quite measurable speedup :)

Add PROP_NO_DEG_UPDATE to remesh props.

Did this get lost? or was it committed separately.

Oh you're right, seems like that got lost when i accidentally committed this because it was in another local commit and fabricator replaced the code.

Paul Kotelevets (1D_Inc) awarded a token.Sep 15 2022, 10:04 AM

Thanks Jacques, makes sense.

On the code side the change seems good to me. So if you've tested it and confident go ahead with the commit :)

Evan Wilson (EAW) awarded a token.Sep 19 2022, 7:35 AM

Closed by commit rBbad55d56bc71: Mesh: Parallelize remesh reprojections (authored by Erik Abrahamsson (erik85)). · Explain WhyNov 2 2022, 11:25 PM

This revision was automatically updated to reflect the committed changes.

Erik Abrahamsson (erik85) added a commit: rBbad55d56bc71: Mesh: Parallelize remesh reprojections.

Aras Pranckevicius (aras_p) awarded a token.Nov 7 2022, 5:19 PM

Metin Seven (MetinSeven) awarded a token.Nov 8 2022, 10:16 AM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Nov 8 2022, 10:27 AM