WM Modal Keymaps: Add accessors to modal event values.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Aug 8 2022, 6:57 PM.

Details

Reviewers

Commits

rB2de1b0628702: I18n: add extraction of modal event names.
rBefc1d4bb9aa3: WM Modal Keymaps: Add accessors to modal event values.
rB630b961f234e: I18n: add extraction of modal event names.
rB2682a59efe53: WM Modal Keymaps: Add accessors to modal event values.

Summary

It is currently impossible to access modal keymaps' event values (from
propvalue enum) from python code (for API introspection).

This is needed for i18n messages extraction (see D15607).

NOTE: those changes will be committed in two different commits (one per file).

This is an alternative fix to the solution proposed in D15607.

Diff Detail

Repository: rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Aug 8 2022, 6:57 PM

Bastien Montagne (mont29) created this revision.

Harbormaster completed remote builds in B23297: Diff 54500.Aug 8 2022, 6:58 PM

Bastien Montagne (mont29) mentioned this in D15607: I18n: make more parts of the UI translatable.Aug 8 2022, 6:59 PM

Damien Picard (pioverfour) mentioned this in T43295: Translation disambiguation requests.Aug 9 2022, 12:49 AM

Campbell Barton (campbellbarton) accepted this revision.Aug 9 2022, 8:56 AM

This revision is now accepted and ready to land.Aug 9 2022, 8:56 AM

Campbell Barton (campbellbarton) awarded a token.Aug 9 2022, 8:59 AM

Only minor comment, LGTM.

source/blender/makesrna/intern/rna_wm.c
877–879	Use `RNA_enum_items_count`

Bastien Montagne (mont29) marked an inline comment as done.Aug 9 2022, 11:48 AM

Closed by commit rB2682a59efe53: WM Modal Keymaps: Add accessors to modal event values. (authored by Bastien Montagne (mont29)). · Explain WhyAug 9 2022, 12:36 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rB2682a59efe53: WM Modal Keymaps: Add accessors to modal event values..

Bastien Montagne (mont29) added a commit: rB630b961f234e: I18n: add extraction of modal event names..

Campbell Barton (campbellbarton) added a commit: rBefc1d4bb9aa3: WM Modal Keymaps: Add accessors to modal event values..Aug 9 2022, 1:09 PM

Campbell Barton (campbellbarton) added a commit: rB2de1b0628702: I18n: add extraction of modal event names..

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_wm.c

32 lines

Diff 54533

View Options

source/blender/makesrna/intern/rna_wm.c

WM Modal Keymaps: Add accessors to modal event values.ClosedPublicActions