There is a new enum type, eTimeMarkerFlags, that holds all the
possible marker flag values.
For back compatibility, the value of TIME_MARKER_FLAG_SELECTED matches
the global flag SELECTED.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- master
- Build Status
Buildable 23353 Build 23353: arc lint + arc unit
Event Timeline
Comment Actions
Prefer to keep SELECT, as this convention is typical for selectable elements in DNA, just note in the enum definition that (1 << 0) is reserved for SELECT.
It looks like TIME_MARKER_FLAG_ACTIVE is never set. As far as I can tell it's an error that marker_get_icon_id even checks it (perhaps it made sense when added, would need to check history, nevertheless, it's not set now), it can be removed as part of a separate patch.
| source/blender/makesdna/DNA_scene_types.h | ||
|---|---|---|
| 858 | There should be a doc-string describing what the flag is for, as this is a run-time tag, it could be called: TIME_MARKER_FLAG_TAG, with a note that it's expected to be cleared after use. | |
Comment Actions
*Edit* noticed this is operating on a copy of the markers, using a flag in this case seems OK, .
| source/blender/editors/animation/anim_markers.c | ||
|---|---|---|
| 643–645 | Unrelated to this patch, clearing this flag seems unnecessary, this is operating on a copy of the markers. | |