Redo Panel Barrier
AbandonedPublic
Actions

Authored by Joseph Eagar (joeedh) on Aug 15 2022, 11:00 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T101743: Regression: Redo panel created on sculpting

Summary

This patch adds a new operator flag to clear the redo panel. It's useful for operators that aren't registered but shouldn't be jumped over by the redo panel (like the sculpt brush stroke operator).

Diff Detail

Event Timeline

Joseph Eagar (joeedh) requested review of this revision.Aug 15 2022, 11:00 PM

Joseph Eagar (joeedh) created this revision.

Julien Kaspar (JulienKaspar) added a project: Sculpt, Paint & Texture.Aug 23 2022, 10:58 AM

Sync with latest master

Julien Kaspar (JulienKaspar) added a task: T101743: Regression: Redo panel created on sculpting.Oct 20 2022, 10:52 AM

Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Oct 20 2022, 11:25 AM

Campbell Barton (campbellbarton) mentioned this in D16523: WM: operators that add their own undo pushes now clears the redo panel.Nov 16 2022, 7:43 AM

From looking into this, sculpt is performing an undo but the absence of the OPTYPE_UNDO flag prevents the redo popup from being closed.

Submitted a separate diff D16523: WM: operators that add their own undo pushes now clears the redo panel address this issue more generally by detecting when an undo step was added without the need for operators to add a separate flag.