Page MenuHome

Fix T99872: Crash Loading Embedded Fonts - 3.3
ClosedPublic

Authored by Harley Acheson (harley) on Aug 16 2022, 8:32 PM.

Details

Summary

Ensure kerning cache exists when loading embedded fonts


When loading embedded fonts from memory the font->kerning_cache is not created and so we get a crash if the font does support kerning. This was not caught because the loading of packed fonts was not actually doing anything in VSE until {523bc981cfee}.

We have since consolidated blf_font_new and blf_font_new_from_mem into a single function so that they cannot get out of sync like this any more. So this fix is specific to Blender 3.3. But we can add this as a candidate for corrective release 3.2.3

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Aug 16 2022, 8:32 PM
Harley Acheson (harley) created this revision.

I missed this version of the patch. Looks fine to me to commit to blender-v3.3-release.

CC @Sergey Sharybin (sergey).

This revision is now accepted and ready to land.Nov 8 2022, 7:26 PM

To me it also looks fine for the 3.3 branch. I've also verified that the crash is fixed.