Differential D15705

Fix T100258: Divide spline total length to integer total length of curves
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Aug 17 2022, 12:08 AM.

Tags

Subscribers

None

Tokens

"Like" token, awarded by PratikPB2123.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T100258: Regression: Geometry Nodes > Spline Parameter > Factor Output

Commits

rB5fff6c419c54: Fix T100258: wrong spline length used in Spline Parameter node

Summary

The total length of the curves is the float. A mistake was made due to which it was int. In later calculations, this caused inaccuracies.

Diff Detail

Repository: rB Blender

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Aug 17 2022, 12:08 AM

Iliya Katueshenock (Moder) created this revision.

Iliya Katueshenock (Moder) added a task: T100258: Regression: Geometry Nodes > Spline Parameter > Factor Output.

Formating*

Oops! Thanks for the fix.

This revision is now accepted and ready to land.Aug 17 2022, 2:41 AM

Pratik Borhade (PratikPB2123) awarded a token.Aug 20 2022, 1:20 PM

Closed by commit rB5fff6c419c54: Fix T100258: wrong spline length used in Spline Parameter node (authored by Iliya Katueshenock (Moder), committed by Jacques Lucke (JacquesLucke)). · Explain WhyAug 22 2022, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB5fff6c419c54: Fix T100258: wrong spline length used in Spline Parameter node.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_curve_spline_parameter.cc

4 lines

Diff 54888

source/blender/nodes/geometry/nodes/node_geo_curve_spline_parameter.cc

Loading...