Differential D15710
Fix T98954: Color management is very slow with sequencer sound Authored by Richard Antalik (ISS) on Aug 17 2022, 6:21 AM. Tags None Subscribers None
Details Function rna_ColorManagement_update tagged unnecesary updates. I am not 100% sure that descripton is correct, but I can't find any area where this update was needed. Sequencer works well without this as well as render engines.
Diff Detail
Event TimelineComment Actions The tagging was added in the rB60ff60dcdc9 and was needed for rB29f6616d609. The way how Cycles draws the render result in the viewport has been changed, but other render engines might still follow the older style of draw integration. So it is important to have tagging to happen so that external engines can see that the scene changed, but it is probably OK to rely on a copy-on-witte tag happening as part of generic RNA update handling. Comment Actions This looks fine by itself. But searching the code I see many more instances of DEG_id_tag_update(&scene->id, 0). So to avoid those operations being slow it would be good to go over them and replace 0 by ID_RECALC_COPY_ON_WRITE where possible. Comment Actions
It is good to move away from tag of 0 to the proper tag. But please be mindful suggesting ID_RECALC_COPY_ON_WRITE. From the comment: This is most generic tag which should only be used when nothing else matches. Comment Actions I would suggest to keep this patch as is then. At least it would be strictly related to report. My guess would be, that for images and movies tagging is not even needed, but will have to check what is evaluated there to be sure, and still there could be non-obvious relations. Comment Actions This patch should go as it is, yes. This is why it is set to green from both mine and Brecht's side ;) |