This patch fixes:
- the call of LibFree on a unfinished loaded library;
- memory leak created on end of game : the async libraries are loaded but not converted, so not freed with the master scene.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- ge_async_libload
Event Timeline
Comment Actions
Mostly looks good. Just some minor tweaks. Also, was this tested with memcheck (Valgrind) and/or Helgrind?
| source/gameengine/Converter/KX_BlenderSceneConverter.cpp | ||
|---|---|---|
| 184 | You should add a comment on why this now needs to be here (e.g., must be called after X to avoid a memory leak). | |
| 1039 | I would like to keep I/O consistent. The rest of this file is using printf(), so I'd stick with that. | |
| source/gameengine/Converter/KX_LibLoadStatus.h | ||
| 47 | We might as well expose this to Python since it's one extra line to add it to KX_LibLoadStatus::Attributes. | |
| 74 | I would prefer this to be IsFinished() | |
| source/gameengine/Converter/KX_LibLoadStatus.cpp | ||
|---|---|---|
| 39–40 | 0.0f | |
Comment Actions
- Rename GetFinished to IsFinished, expose m_finished in python : "finished", add comment.
Comment Actions
It is necessary to add "finished" attribute to rst docs. Other than this, looks good to me
This comment was removed by Porteries Tristan (panzergame).