Differential D15724

Fix T99576: Guard against crash due to invalid names in BKE_id_attribute_remove
ClosedPublic
Actions

Authored by Tom Edwards (artfunkel) on Aug 18 2022, 7:46 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T99576: Crash in BKE_mesh_minmax

Commits

rB35df9f80b9c7: Fix T99576: Guard against empty names when removing attributes

Summary

It's possible for misbehaving scripts written before 3.3 to reach this state and crash Blender. With this change, the error is reduced to a Python exception.

T99576

Diff Detail

Repository: rB Blender

Event Timeline

Tom Edwards (artfunkel) requested review of this revision.Aug 18 2022, 7:46 PM

Tom Edwards (artfunkel) created this revision.

Tom Edwards (artfunkel) retitled this revision from Fix T99576: Guard against invalid names in BKE_id_attribute_remove to Fix T99576: Guard against crash due to invalid names in BKE_id_attribute_remove.Aug 18 2022, 10:24 PM

Robert Guetzkow (rjg) added a task: T99576: Crash in BKE_mesh_minmax.Aug 18 2022, 10:58 PM

Thanks for the patch!

This revision is now accepted and ready to land.Aug 19 2022, 2:02 AM

Closed by commit rB35df9f80b9c7: Fix T99576: Guard against empty names when removing attributes (authored by Tom Edwards (artfunkel), committed by Hans Goudey (HooglyBoogly)). · Explain WhyAug 29 2022, 9:54 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB35df9f80b9c7: Fix T99576: Guard against empty names when removing attributes.

I changed the message to be a bit more specific in the final commit.