If reroute node lies in side the frame node boundaries then set
frame node as the parent of reroute
Details
Details
- Reviewers
Hans Goudey (HooglyBoogly) Leon Schittek (lone_noel) - Maniphest Tasks
- T98968: Reroute node created within a frame doesn't belongs to the frame automatically
- Commits
- rB68487cff95b3: Fix T98968: Node reroute tool doesn't add to frames
rB50e5c787995c: Fix T98968: Node reroute tool doesn't add to frames
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Works as expected in all cases I've tried!
There are some corner cases, like when the reroute happens to be created
on top of a frame despite none of the links actually being inside the frame. But I think
those are probably rare in practice and being predictable seems better than trying to
be smart about it.
Will leave the final call to @Hans Goudey (HooglyBoogly)!
| Example of behavior mentioned above |
| source/blender/editors/space_node/node_add.cc | ||
|---|---|---|
| 215–219 | It wonder if it's nicer to iterate through the nodes backwards until we find the first frame node to attach to. | |