Paths

Table of Contentst

Differential D1576

BGE: Fix T46557: Empty collision bounds option with character physics
ClosedPublic
Actions

Authored by Ulysse Martin (youle) on Oct 24 2015, 6:46 PM.

Tags

Subscribers

Jorge Bernal (lordloki)

Details

Reviewers

Campbell Barton (campbellbarton)
Porteries Tristan (panzergame)
Jorge Bernal (lordloki)

Maniphest Tasks

T46557: [BUG] BGE steering

Commits

rBS40b2e75b2018: BGE: Fix T46557: Empty collision bounds option with character physics
rB40b2e75b2018: BGE: Fix T46557: Empty collision bounds option with character physics

Summary

Fix T46557: Empty collision bounds option with character physics.

Fix in rna_object.c rna_GameObjectSettings_physics_type_set->The collision bounds type can't be empty for character physics
Add something in versioning_270.c for the .blends already saved with collision bounds option empty (characters)

Diff Detail

Event Timeline

Ulysse Martin (youle) updated this revision to Diff 5272.Oct 24 2015, 6:46 PM

Ulysse Martin (youle) retitled this revision from to BGE: Fix T46557: Empty collision bounds option with character physics.

Ulysse Martin (youle) updated this object.

Ulysse Martin (youle) added reviewers: Porteries Tristan (panzergame), Campbell Barton (campbellbarton).

Ulysse Martin (youle) added a project: Game Engine.

Ulysse Martin (youle) added a task: T46557: [BUG] BGE steering.

It looks good to me.

source/blender/blenloader/intern/versioning_270.c
868–869	Can you merge the condition ? : `if (ob->body_type == OB_BODY_TYPE_CHARACTER && (ob->gameflag & OB_BOUNDS) && ob->collision_boundtype == OB_BOUND_TRIANGLE_MESH)`

This revision is now accepted and ready to land.Oct 24 2015, 8:39 PM

Merged

Jorge Bernal (lordloki) requested changes to this revision.Oct 28 2015, 12:43 AM

Jorge Bernal (lordloki) added a reviewer: Jorge Bernal (lordloki).

Jorge Bernal (lordloki) added a subscriber: Jorge Bernal (lordloki).

Jorge Bernal (lordloki) added inline comments.

source/blender/blenloader/intern/versioning_270.c
869	You shouldn't insert the body type character check into the bPoseChannel->custom_scale loop. It should have its own loop. Other than this, looks ok to me.

This revision now requires changes to proceed.Oct 28 2015, 12:43 AM

@Jorge Bernal (lordloki): Ah yes, I didn't noticed, sorry, I'm very scatterbrained :) Thanks for review. I hope I made no other mistake

Jorge Bernal (lordloki) accepted this revision.Oct 28 2015, 2:02 AM

Jorge Bernal (lordloki) edited edge metadata.

This revision is now accepted and ready to land.Oct 28 2015, 2:02 AM

Closed by commit rB40b2e75b2018: BGE: Fix T46557: Empty collision bounds option with character physics (authored by Ulysse Martin (youle), committed by Jorge Bernal (lordloki)). · Explain WhyOct 28 2015, 2:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

versioning_270.c

6 lines

makesrna/

intern/

5 lines

Diff 5317

source/blender/blenloader/intern/versioning_270.c

Loading...

source/blender/makesrna/intern/rna_object.c

Loading...