Fix WITH_CYCLES_ONEAPI_BINARIES issues with make release
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 24 2022, 2:42 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBe65f0337e942: Fix WITH_CYCLES_ONEAPI_BINARIES issues with make release

Summary

Fix typo in blender_release.cmake, and ensure that "make release" still works
when ocloc is not available. While a fatal error is useful for debugging, the
current convention is to disable features, especially in cases like this where
there is no simple way to make the feature work.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 23472
Build 23472: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Aug 24 2022, 2:42 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B23472: Diff 54945.Aug 24 2022, 2:42 PM

Sergey Sharybin (sergey) requested changes to this revision.Aug 24 2022, 2:57 PM

Sergey Sharybin (sergey) added inline comments.

intern/cycles/kernel/CMakeLists.txt
789–791	I am not convinced this can be removed. This will break the following configurations: Our Linux builders, where we do not pass explicit `OCLOC_INSTALL_DIR` and it is to be derived based on on a relative location from the SYCL compiler. This is also how the official DPC++ package from Intel was initially used, which includes its own `ocloc`.