Differential D15780
Fix T100595: Lineart screenspace thickness ignores Resolution Percentage Authored by Philipp Oeser (lichtwerk) on Aug 25 2022, 1:05 PM.
Details When changing the Render Resolution Percentage, screenspace thickness Would assume this is what artists expect, did not check if similar
Diff Detail
Event TimelineComment Actions The change looks logic, but I would like to hear the opinion of @Clément Foucault (fclem) before changing anything in the Draw Engine code. Comment Actions Well, that's quite a breaking change. Things like wireframe shader also do not respect the scaling factor. So i am unsure if we should fix this. But it does make sense. However I don't like where it gets injected.
Comment Actions Got a hint for a better place? Comment Actions Would assume the wireframe shader deserves to be fixed as well then (separately)? Cannot think of a scenario where you would actually want the current behavior. Comment Actions I'm sorry, I didn't meant to send that in the end. But if that's something we want to fix for all screen space radii, we better put it in the ViewInfos instead and do the multiplication in the shader. The scaling you mentioned is a workaround that was introduced to keep compatibility with old grease pencil when we refactored the engine. Comment Actions If that is the only way forward, there is probably no point in keeping this. Comment Actions Just checking: this should still only affect rendering, right? (we dont want to change anything for the viewport when changing render percentage if I am not mistaken) Comment Actions Yes. But this does pauses a question about viewport camera view + zooming in-out in it. Should this also increase the screenspace size? Should it be proportional to the render size? For me, it should. But I would also check with @Brecht Van Lommel (brecht) if we can also change the behavior of the wireframe shader in cycles so that it is kept in sync with what EEVEE does. Comment Actions I'm not sure it's worth doing this for wireframes? If you use them for NPR purposes it could be useful, but for a typical render to show off topology I expect a wireframe with just enough thickness to be readable is what you want at all resolutions. Comment Actions @Brecht Van Lommel (brecht) I took the wireframe node as an example, but to me anything labelled as in pixel units inside the shader system should behave consistently. IIRC it is the only shader node that has a pixel unit property. | ||||||||||