Paths

Table of Contentst

Differential D15783

Fix T100255: Make RigidBodyWorld (and effector_weights) collections refcounted.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Aug 25 2022, 2:54 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB500d81547896: Fix T100255: Make RigidBodyWorld (and effector_weights) collections refcounted.

Summary

Those collections were so far mainly just tagged as fake user (even
though a few places in code already incremented usercount on them).

Since we now clear the fakeuser flag when linking/appending data, ensure
that these collections are preserved by making these usages regular ID
refcounting ones.

Diff Detail

Repository: rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Aug 25 2022, 2:54 PM

Bastien Montagne (mont29) created this revision.

Harbormaster completed remote builds in B23485: Diff 54972.Aug 25 2022, 2:54 PM

I see an effector_weights in dynamic paint, softbody, fluids and cloth as well. I think those are missing a change to IDWALK_CB_USER.

This revision now requires changes to proceed.Aug 25 2022, 3:01 PM

Add missing EffectorsWeights->group IDWALK_CB_USER tagging.

Harbormaster completed remote builds in B23486: Diff 54973.Aug 25 2022, 3:10 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 25 2022, 3:16 PM

This revision is now accepted and ready to land.Aug 25 2022, 3:16 PM

Closed by commit rB500d81547896: Fix T100255: Make RigidBodyWorld (and effector_weights) collections refcounted. (authored by Bastien Montagne (mont29)). · Explain WhyAug 25 2022, 5:22 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rB500d81547896: Fix T100255: Make RigidBodyWorld (and effector_weights) collections refcounted..

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

object.cc

2 lines

particle.c

2 lines

rigidbody.c

13 lines

editors/

physics/

rigidbody_constraint.c

2 lines

makesrna/

intern/

rna_object_force.c

2 lines

rna_rigidbody.c

4 lines

modifiers/

intern/

MOD_cloth.c

2 lines

MOD_dynamicpaint.c

2 lines

MOD_fluid.c

2 lines

Diff 54977

View Options

source/blender/blenkernel/intern/object.cc

View Options

source/blender/blenkernel/intern/particle.c

View Options

source/blender/blenkernel/intern/rigidbody.c

View Options

source/blender/editors/physics/rigidbody_constraint.c

View Options

source/blender/makesrna/intern/rna_object_force.c

View Options

source/blender/makesrna/intern/rna_rigidbody.c

View Options

source/blender/modifiers/intern/MOD_cloth.c

View Options

source/blender/modifiers/intern/MOD_dynamicpaint.c

View Options

source/blender/modifiers/intern/MOD_fluid.c

Fix T100255: Make RigidBodyWorld (and effector_weights) collections refcounted.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54977

source/blender/blenkernel/intern/object.cc

source/blender/blenkernel/intern/particle.c

source/blender/blenkernel/intern/rigidbody.c

source/blender/editors/physics/rigidbody_constraint.c

source/blender/makesrna/intern/rna_object_force.c

source/blender/makesrna/intern/rna_rigidbody.c

source/blender/modifiers/intern/MOD_cloth.c

source/blender/modifiers/intern/MOD_dynamicpaint.c

source/blender/modifiers/intern/MOD_fluid.c

Fix T100255: Make RigidBodyWorld (and effector_weights) collections refcounted.
ClosedPublic
Actions

Revision Contents
Changeset List