Page MenuHome

Cycles: remove old Sobol pattern, simplify sampling dimensions
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Aug 26 2022, 2:15 PM.

Details

Summary

The multi-dimensional Sobol pattern required us to carefully use as low
dimensions as possible, as quality goes down in higher dimensions. Now that we
have two sampling patterns that are at least as good, there is no need to keep
it around and the implementation can be simplified.

Diff Detail

Repository
rB Blender
Branch
pattern (branched from master)
Build Status
Buildable 23498
Build 23498: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Aug 26 2022, 2:15 PM
Brecht Van Lommel (brecht) created this revision.

No Sobol-Burley adaptive sampling support for now.

This looks good to me!

(Not totally sure what's appropriate for me to do as a reviewer that's still very new to the code base. Should I go ahead and approve it, or wait for Lukas to review?)

This revision is now accepted and ready to land.Aug 29 2022, 8:24 PM

Gah. Not used to Phabricator. Don't mind me. Just pressing random buttons accidentally while trying to figure things out.