Cycles: remove old Sobol pattern, simplify sampling dimensions
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 26 2022, 2:15 PM.

Details

Reviewers

Nathan Vegdahl (cessen)
Lukas Stockner (lukasstockner97)

Commits

rB60119daef569: Cycles: remove old Sobol pattern, simplify sampling dimensions

Summary

The multi-dimensional Sobol pattern required us to carefully use as low
dimensions as possible, as quality goes down in higher dimensions. Now that we
have two sampling patterns that are at least as good, there is no need to keep
it around and the implementation can be simplified.

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Aug 26 2022, 2:15 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B23498: Diff 54998.Aug 26 2022, 2:15 PM

No Sobol-Burley adaptive sampling support for now.

Harbormaster completed remote builds in B23501: Diff 55006.Aug 26 2022, 5:46 PM

Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)Aug 26 2022, 5:46 PM

This looks good to me!

(Not totally sure what's appropriate for me to do as a reviewer that's still very new to the code base. Should I go ahead and approve it, or wait for Lukas to review?)

This revision is now accepted and ready to land.Aug 29 2022, 8:24 PM

Gah. Not used to Phabricator. Don't mind me. Just pressing random buttons accidentally while trying to figure things out.

Nathan Vegdahl (cessen) mentioned this in D15746: Cycles: fix Progressive Multi-Jittered sampling..Aug 29 2022, 11:24 PM

Closed by commit rB60119daef569: Cycles: remove old Sobol pattern, simplify sampling dimensions (authored by Brecht Van Lommel (brecht)). · Explain WhySep 1 2022, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB60119daef569: Cycles: remove old Sobol pattern, simplify sampling dimensions.

Brecht Van Lommel (brecht) mentioned this in rBL63017: Tests: update for PMJ pattern changes.

Brecht Van Lommel (brecht) mentioned this in rBL63018: Tests: update grease pencil test for PMJ pattern changes.Sep 2 2022, 5:31 PM