Page MenuHome
Differential D15791

I18n: disambiguate and make a few more strings translatable
ClosedPublic
Actions

Authored by Damien Picard (pioverfour) on Aug 26 2022, 4:56 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rB9120c86c3fca: I18n: disambiguate and make a few more strings translatable
Summary

Those strings were at least partly disambiguated:

  • Area
    • Zone
    • Measurement
  • Ease
    • BBone Ease In / Out
  • Back
    • Camera BG image depth
    • GP interpolate sequence
  • Edge Crease
    • Theme
  • Jitter
    • Brush
    • GPencil
    • Lens distorsion compositing node
  • Cineon color management
    • Black
    • Gamma
    • White

Diff Detail

Repository
rB Blender

Event Timeline

Damien Picard (pioverfour) requested review of this revision.Aug 26 2022, 4:56 PM
Damien Picard (pioverfour) created this revision.
Damien Picard (pioverfour) mentioned this in T43295: Translation disambiguation requests.Aug 26 2022, 5:00 PM
Bastien Montagne (mont29) requested changes to this revision.Aug 29 2022, 2:50 PM
Bastien Montagne (mont29) added inline comments.
source/blender/blentranslation/BLT_translation.h
81–82 ↗(On Diff #55003)

Not sure we really need those two tbh, would expect Theme to use under the WM ID type, and the curveprofile could use either the ME or OB ID types?

source/blender/makesrna/intern/rna_scene.c
5821–5835

We still need proper formal definition of those in BLT_translation.h, all i18n contexts should be handled in a same way, to also ensure that the python api is aware of them.

This revision now requires changes to proceed.Aug 29 2022, 2:50 PM
Damien Picard (pioverfour) added inline comments.Aug 29 2022, 2:58 PM
source/blender/blentranslation/BLT_translation.h
81–82 ↗(On Diff #55003)

The Modeling was just to avoid duplication, and for the Theme I hadn’t thought of that.

Thanks!

source/blender/makesrna/intern/rna_scene.c
5821–5835

Understood! So it’s not an issue to add contexts just for one-shot uses like this? I really didn’t see what existing contexts could be used unambiguously. For the “generic” ones I added, I felt like they could be reused at later points but for cineon, not so sure :D

Anyway I’ll create a BLT_I18NCONTEXT_CINEON context if that makes sense.

Damien Picard (pioverfour) updated this revision to Diff 55069.Aug 29 2022, 3:25 PM
Damien Picard (pioverfour) edited the summary of this revision. (Show Details)
  • Replace literal contexts by a new Cineon one
  • Remove “generic” contexts, Theme and Modeling
Bastien Montagne (mont29) added inline comments.Aug 29 2022, 3:32 PM
source/blender/makesrna/intern/rna_scene.c
5821–5835

Actually just talked with our UI team, we generally discouraged single letters labels, unless very very common widely accepted cases (like X/Y/Z/W for coordinates, or R/G/B/A for colors).

So here proper fix would rather be to replace those by full labels (Black, etc.) instead.

Damien Picard (pioverfour) added inline comments.Aug 29 2022, 3:37 PM
source/blender/makesrna/intern/rna_scene.c
5821–5835

Even better! :D

I guess that means versioning is needed?

Damien Picard (pioverfour) added inline comments.Aug 29 2022, 3:45 PM
source/blender/makesrna/intern/rna_scene.c
5821–5835

Replying to myself, no versioning is needed because the prop name doesn’t change.

Damien Picard (pioverfour) updated this revision to Diff 55070.Aug 29 2022, 3:51 PM
Damien Picard (pioverfour) edited the summary of this revision. (Show Details)

Rename one-letter Cineon props:

B -> Black
W -> White
G -> Gamma

Bastien Montagne (mont29) accepted this revision.Aug 29 2022, 3:54 PM

Thanks!

This revision is now accepted and ready to land.Aug 29 2022, 3:54 PM
Closed by commit rB9120c86c3fca: I18n: disambiguate and make a few more strings translatable (authored by Damien Picard (pioverfour), committed by Bastien Montagne (mont29)). · Explain WhyAug 29 2022, 4:05 PM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rB9120c86c3fca: I18n: disambiguate and make a few more strings translatable.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
10 lines
3 lines
source/
blender/
editors/
gpencil/
1 line
interface/
4 lines
mesh/
1 line
space_graph/
6 lines
makesrna/
intern/
4 lines
5 lines
3 lines
3 lines
1 line
6 lines
1 line
1 line

Diff 55072

View Options

release/scripts/startup/bl_ui/properties_data_bone.py

Loading...
View Options

release/scripts/startup/bl_ui/space_info.py

Loading...
View Options

source/blender/editors/gpencil/gpencil_interpolate.c

Loading...
View Options

source/blender/editors/interface/interface_templates.c

Loading...
View Options

source/blender/editors/mesh/editmesh_select_similar.c

Loading...
View Options

source/blender/editors/space_graph/graph_buttons.c

Loading...
View Options

source/blender/makesrna/intern/rna_armature.c

Loading...
View Options

source/blender/makesrna/intern/rna_brush.c

Loading...
View Options

source/blender/makesrna/intern/rna_camera.c

Loading...
View Options

source/blender/makesrna/intern/rna_curveprofile.c

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/makesrna/intern/rna_scene.c

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...