Details

Reviewers

Maniphest Tasks

T93602: Struct of Arrays Refactor for Mesh Vertices
T95967: Struct of Arrays Refactor for Mesh Polygons
T95965: Mesh Struct of Arrays Refactor
T95966: Struct of Arrays Refactor for Mesh Edges

Commits

rB12becbf0dffe: Mesh: Move selection flags to generic attributes

Summary

Using the attribute name semantics from T97452, this patch moves the
selection status of mesh elements from the SELECT of vertices, and
edges, and the ME_FACE_SEL of faces to generic boolean attribute
Storing this data as generic attributes can significantly simplify and
improve code, as described in T95965.

The attributes are called .selection_vert, .selection_edge, and
.selection_poly. The . prefix means they are "UI attributes",
so they still contain original data edited by users, but they aren't
meant to be accessed procedurally by the user in arbitrary situations.
They are also be hidden in the spreadsheet and the attribute list.

Until 4.0, the attributes are still written to and read from the mesh
in the old way, so neither forward nor backward compatibility are
affected. This means memory requirements will be increased by one byte
per element when selection is used. When the flags are removed
completely, requirements will decrease.

Further notes:

The MVert flag is empty at runtime now, so it can be ignored.
BMesh is unchanged, otherwise the change would be much larger.
Many tests have slightly different results, since the selection attribute uses more generic propagation. Previously you couldn't really rely on edit mode selections being propagated procedurally. Now it mostly works as expected.

Similar to 2480b55f216c
Ref T95965

Branch: refactor-mesh-selection-generic

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 27 2022, 6:21 AM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) added tasks: T95966: Struct of Arrays Refactor for Mesh Edges, T95965: Mesh Struct of Arrays Refactor, T95967: Struct of Arrays Refactor for Mesh Polygons, T93602: Struct of Arrays Refactor for Mesh Vertices.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Merge master

https://builder.blender.org/admin/#/builders/57/builds/1472

Merge master

https://builder.blender.org/admin/#/builders/57/builds/1482

Hans Goudey (HooglyBoogly) mentioned this in D15890: Fix versioning for incorrectly written custom data.Sep 6 2022, 1:07 AM

Hans Goudey (HooglyBoogly) mentioned this in D15919: Fix: Mesh SoA format conversion skips versioning.Sep 8 2022, 8:43 PM

Cleanups, fixes

Hans Goudey (HooglyBoogly) added a parent revision: D15919: Fix: Mesh SoA format conversion skips versioning.Sep 11 2022, 12:17 AM

Hans Goudey (HooglyBoogly) added a child revision: D15982: Mesh: Move positions to a generic attribute.Sep 16 2022, 12:40 AM

Merge master

Hans Goudey (HooglyBoogly) retitled this revision from Refactor: Move mesh selection flags to generic attributes to Mesh: Move selection flags to generic attributes.Sep 19 2022, 10:20 PM

Merge master

Only one requested change otherwise LGTM.

The term selection is unnecessarily verbose, the term select communicates intent clearly. As far as I can see ".select_vert", ".select_edge", ".select_poly" are reasonable terms for layers, variable names & related API's.

Other remarks:

'lookup_or_default' is used quite a in situations where there may be no selection, BKE_mesh_legacy_convert_selection_layers_to_flags could skip getting the default if the selection doesn't exist.
vgroup_select_verts moves from supporting a NULL hide_verts to accessing default (is there reason to move in this direction? it seems useful to be able to avoid allocating layers that aren't used).

This revision is now accepted and ready to land.Sep 23 2022, 11:36 AM

Thanks for the review.

In D15795#436706, @Campbell Barton (campbellbarton) wrote:

The term selection is unnecessarily verbose, the term select communicates intent clearly. As far as I can see ".select_vert", ".select_edge", ".select_poly" are reasonable terms for layers, variable names & related API's.

I prefer "selection" since it sounds like a noun instead of a verb, but compromising is fine with me. I'm just happy to move forward here.

'lookup_or_default' is used quite a in situations where there may be no selection, BKE_mesh_legacy_convert_selection_layers_to_flags could skip getting the default if the selection doesn't exist.

lookup_or_default doesn't allocate anything when the layer doesn't exist, it uses the virtual array system to give you something that looks like an array but is only a single value.

vgroup_select_verts moves from supporting a NULL hide_verts to accessing default (is there reason to move in this direction? it seems useful to be able to avoid allocating layers that aren't used).

Same as above. Using lookup_or_default instead of the custom data API simplifies code because we don't have to deal with the null checks.

Closed by commit rB12becbf0dffe: Mesh: Move selection flags to generic attributes (authored by Hans Goudey (HooglyBoogly)). · Explain WhySep 23 2022, 5:45 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB12becbf0dffe: Mesh: Move selection flags to generic attributes.

Hans Goudey (HooglyBoogly) mentioned this in D16872: Spreadsheet: Simplify and improve mesh selection filter.Dec 27 2022, 4:18 PM

Mesh: Move selection flags to generic attributesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 55873

source/blender/blenkernel/BKE_mesh.h

source/blender/blenkernel/BKE_mesh_legacy_convert.h

source/blender/blenkernel/BKE_mesh_mapping.h

source/blender/blenkernel/intern/customdata.cc

source/blender/blenkernel/intern/mball_tessellate.c

source/blender/blenkernel/intern/mesh.cc

source/blender/blenkernel/intern/mesh_boolean_convert.cc

source/blender/blenkernel/intern/mesh_calc_edges.cc

source/blender/blenkernel/intern/mesh_evaluate.cc

source/blender/blenkernel/intern/mesh_legacy_convert.cc

source/blender/blenkernel/intern/mesh_mapping.c

source/blender/blenkernel/intern/object_deform.c

source/blender/blenkernel/intern/subdiv_converter_mesh.c

source/blender/blenkernel/intern/subdiv_mesh.cc

source/blender/blenkernel/intern/subsurf_ccg.c

source/blender/blenloader/intern/versioning_400.cc

source/blender/bmesh/intern/bmesh_construct.h

source/blender/bmesh/intern/bmesh_construct.c

source/blender/bmesh/intern/bmesh_mesh_convert.cc

source/blender/draw/intern/draw_cache_extract_mesh_render_data.cc

source/blender/draw/intern/draw_cache_impl_subdivision.cc

source/blender/draw/intern/mesh_extractors/extract_mesh.hh

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_edituv.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines_paint_mask.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_lnor.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_pos_nor.cc

source/blender/editors/armature/armature_skinning.c

source/blender/editors/armature/meshlaplacian.c

source/blender/editors/mesh/editface.cc

source/blender/editors/mesh/mesh_data.cc

source/blender/editors/object/object_modifier.cc

source/blender/editors/object/object_vgroup.cc

source/blender/editors/sculpt_paint/paint_image_proj.c

source/blender/editors/sculpt_paint/paint_vertex.cc

source/blender/editors/sculpt_paint/paint_vertex_color_ops.cc

source/blender/editors/sculpt_paint/paint_vertex_weight_ops.c

source/blender/editors/space_view3d/view3d_select.cc

source/blender/geometry/intern/mesh_merge_by_distance.cc

source/blender/io/collada/MeshImporter.cpp

source/blender/io/wavefront_obj/exporter/obj_export_mesh.cc

source/blender/makesdna/DNA_meshdata_types.h

source/blender/makesrna/intern/rna_mesh.c

source/blender/modifiers/intern/MOD_array.c

source/blender/modifiers/intern/MOD_explode.c

source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc

tests/python/modules/mesh_test.py

Mesh: Move selection flags to generic attributes
ClosedPublic
Actions

Revision Contents
Changeset List