Paths

Table of Contentst

Differential D15799

Cleanup: Remove/replace View Layer macros.
ClosedPublic
Actions

Authored by Monique Dewanchand (mdewanchand) on Aug 27 2022, 11:06 PM.

Tags

Subscribers

Aras Pranckevicius (aras_p)

Tokens

"Like" token, awarded by HooglyBoogly."Like" token, awarded by aras_p."Like" token, awarded by Crumbled.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T73411: Fix ViewLayers cache building

Commits

rB17501c146edc: Cleanup: Remove/replace View Layer macros.

Summary

This patch is a cleanup required before refactoring the view layer syncing
process T73411: Fix ViewLayers cache building.

Remove FIRSTBASE.
Remove LASTBASE.
Remove BASACT.
Remove OBEDIT_FROM_WORKSPACE.
Replace OBACT with BKE_view_layer_active_object.
Replace OBEDIT_FROM_VIEW_LAYER with BKE_view_layer_edit_object.

Diff Detail

Repository: rB Blender

Event Timeline

Monique Dewanchand (mdewanchand) created this revision.Aug 27 2022, 11:06 PM

Harbormaster completed remote builds in B23508: Diff 55030.Aug 27 2022, 11:06 PM

Monique Dewanchand (mdewanchand) requested review of this revision.Aug 27 2022, 11:08 PM

Monique Dewanchand (mdewanchand) added 1 blocking reviewer(s): Bastien Montagne (mont29).

Monique Dewanchand (mdewanchand) added a project: Core.

Monique Dewanchand (mdewanchand) added a task: T73411: Fix ViewLayers cache building.

Bert Van den Bosch (Crumbled) awarded a token.Aug 28 2022, 11:32 AM

Aras Pranckevicius (aras_p) added a subscriber: Aras Pranckevicius (aras_p).Aug 29 2022, 9:55 AM

Aras Pranckevicius (aras_p) awarded a token.Aug 29 2022, 10:01 AM

Looks good, just some minor picky details noted in comments below.

source/blender/blenkernel/BKE_layer.h
546–547	Would be explicit here that this is a getter, and add a `_get` suffix (so `BKE_view_layer_active_object_get` etc.).
source/blender/editors/object/object_select.c
781	Better to put the comment above then, than having this weird line wrap ;)

This revision now requires changes to proceed.Aug 29 2022, 1:57 PM

Add _get suffix to BKE_view_layer_active_object and BKE_view_layer_edit_object
Move comments.

Harbormaster completed remote builds in B23532: Diff 55082.Aug 29 2022, 7:33 PM

Monique Dewanchand (mdewanchand) marked an inline comment as done.Aug 29 2022, 7:35 PM

Hans Goudey (HooglyBoogly) awarded a token.Aug 29 2022, 7:44 PM

Looks good to go :)

This revision is now accepted and ready to land.Aug 31 2022, 9:45 AM

Closed by commit rB17501c146edc: Cleanup: Remove/replace View Layer macros. (authored by Monique Dewanchand (mdewanchand), committed by monique (monique)). · Explain WhySep 1 2022, 10:22 AM

This revision was automatically updated to reflect the committed changes.

monique (monique) added a commit: rB17501c146edc: Cleanup: Remove/replace View Layer macros..

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

2 lines

intern/

2 lines

3 lines

25 lines

lib_override.cc

6 lines

4 lines

2 lines

draw/

engines/

overlay/

overlay_extra.c

2 lines

intern/

2 lines

14 lines

editors/

animation/

4 lines

armature/

editarmature_undo.c

2 lines

6 lines

curve/

editcurve_add.c

3 lines

editcurve_undo.c

2 lines

editfont_undo.c

3 lines

interface/

interface_ops.cc

2 lines

lattice/

editlattice_undo.c

2 lines

mesh/

editmesh_path.c

2 lines

editmesh_undo.c

2 lines

metaball/

editmball_undo.c

2 lines

object/

22 lines

object_collection.c

3 lines

object_constraint.c

4 lines

12 lines

2 lines

object_modifier.cc

3 lines

object_relations.c

4 lines

object_select.c

12 lines

physics/

particle_edit.c

3 lines

particle_edit_undo.c

5 lines

rigidbody_constraint.c

5 lines

screen/

screen_context.c

6 lines

4 lines

sculpt_paint/

paint_image_ops_paint.cc

3 lines

paint_image_proj.c

3 lines

3 lines

7 lines

17 lines

space_buttons/

buttons_context.c

4 lines

buttons_texture.c

2 lines

space_clip/

tracking_ops_orient.c

4 lines

space_image/

3 lines

5 lines

space_info/

8 lines

space_outliner/

outliner_collections.cc

4 lines

outliner_edit.cc

3 lines

outliner_intern.hh

2 lines

outliner_select.cc

24 lines

outliner_sync.cc

4 lines

outliner_tools.cc

6 lines

outliner_tree.cc

2 lines

outliner_utils.cc

2 lines

space_view3d/

4 lines

view3d_buttons.c

5 lines

view3d_cursor_snap.c

3 lines

2 lines

view3d_gizmo_armature.c

6 lines

view3d_gizmo_camera.c

10 lines

view3d_gizmo_empty.c

4 lines

view3d_gizmo_forcefield.c

4 lines

view3d_gizmo_light.c

12 lines

view3d_gizmo_ruler.c

3 lines

view3d_header.c

5 lines

view3d_navigate.c

12 lines

view3d_select.cc

25 lines

17 lines

transform/

8 lines

transform_convert.c

4 lines

transform_convert_action.c

3 lines

transform_convert_gpencil.c

3 lines

transform_convert_graph.c

3 lines

transform_convert_object.c

4 lines

transform_convert_object_texspace.c

3 lines

transform_convert_particle.c

7 lines

transform_convert_sculpt.c

7 lines

transform_generics.c

10 lines

transform_gizmo_3d.c

8 lines

transform_orientations.c

2 lines

transform_snap.c

3 lines

undo/

14 lines

util/

2 lines

makesdna/

DNA_scene_types.h

8 lines

makesrna/

intern/

4 lines

4 lines

rna_sculpt_paint.c

17 lines

8 lines

nodes/

geometry/

node_geometry_tree.cc

3 lines

shader/

node_shader_tree.cc

3 lines

texture/

node_texture_tree.c

3 lines

windowmanager/

intern/

wm_toolsystem.c

5 lines

Diff 55180

source/blender/blenkernel/BKE_layer.h

Loading...

source/blender/blenkernel/intern/collection.c

Loading...

source/blender/blenkernel/intern/fluid.c

Loading...

source/blender/blenkernel/intern/layer_utils.c

Loading...

source/blender/blenkernel/intern/lib_override.cc

Loading...

source/blender/blenkernel/intern/object.cc

Loading...

source/blender/blenkernel/intern/scene.cc

Loading...

source/blender/draw/engines/overlay/overlay_extra.c

Loading...

source/blender/draw/intern/DRW_render.h

Loading...

source/blender/draw/intern/draw_manager.c

Loading...

source/blender/editors/animation/anim_filter.c

Loading...

source/blender/editors/armature/editarmature_undo.c

Loading...

source/blender/editors/armature/pose_select.c

Loading...

source/blender/editors/curve/editcurve_add.c

Loading...

source/blender/editors/curve/editcurve_undo.c

Loading...

source/blender/editors/curve/editfont_undo.c

Loading...

source/blender/editors/interface/interface_ops.cc

Loading...

source/blender/editors/lattice/editlattice_undo.c

Loading...

source/blender/editors/mesh/editmesh_path.c

Loading...

source/blender/editors/mesh/editmesh_undo.c

Loading...

source/blender/editors/metaball/editmball_undo.c

Loading...

source/blender/editors/object/object_add.cc

Loading...

source/blender/editors/object/object_collection.c

Loading...

source/blender/editors/object/object_constraint.c

Loading...

source/blender/editors/object/object_edit.c

Loading...

source/blender/editors/object/object_modes.c

Loading...

source/blender/editors/object/object_modifier.cc

Loading...

source/blender/editors/object/object_relations.c

Loading...

source/blender/editors/object/object_select.c

Loading...

source/blender/editors/physics/particle_edit.c

Loading...

source/blender/editors/physics/particle_edit_undo.c

Loading...

source/blender/editors/physics/rigidbody_constraint.c

Loading...

source/blender/editors/screen/screen_context.c

Loading...

source/blender/editors/screen/screen_edit.c

Loading...

source/blender/editors/sculpt_paint/paint_image_ops_paint.cc

Loading...

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...

source/blender/editors/sculpt_paint/paint_utils.c

Loading...

source/blender/editors/sculpt_paint/sculpt_ops.c

Loading...

source/blender/editors/sculpt_paint/sculpt_undo.c

Loading...

source/blender/editors/space_buttons/buttons_context.c

Loading...

source/blender/editors/space_buttons/buttons_texture.c

Loading...

source/blender/editors/space_clip/tracking_ops_orient.c

Loading...

source/blender/editors/space_image/image_edit.c

Loading...

source/blender/editors/space_image/space_image.c

Loading...

source/blender/editors/space_info/info_stats.cc

Loading...

source/blender/editors/space_outliner/outliner_collections.cc

Loading...

source/blender/editors/space_outliner/outliner_edit.cc

Loading...

source/blender/editors/space_outliner/outliner_intern.hh

Loading...

source/blender/editors/space_outliner/outliner_select.cc

Loading...

source/blender/editors/space_outliner/outliner_sync.cc

Loading...

source/blender/editors/space_outliner/outliner_tools.cc

Loading...

source/blender/editors/space_outliner/outliner_tree.cc

Loading...

source/blender/editors/space_outliner/outliner_utils.cc

Loading...

source/blender/editors/space_view3d/space_view3d.c

Loading...

source/blender/editors/space_view3d/view3d_buttons.c

Loading...

source/blender/editors/space_view3d/view3d_cursor_snap.c

Loading...

source/blender/editors/space_view3d/view3d_draw.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_armature.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_camera.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_empty.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_forcefield.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_light.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_ruler.c

Loading...

source/blender/editors/space_view3d/view3d_header.c

Loading...

source/blender/editors/space_view3d/view3d_navigate.c

Loading...

source/blender/editors/space_view3d/view3d_select.cc

Loading...

source/blender/editors/space_view3d/view3d_view.c

Loading...

source/blender/editors/transform/transform.c

Loading...

source/blender/editors/transform/transform_convert.c

Loading...

source/blender/editors/transform/transform_convert_action.c

Loading...

source/blender/editors/transform/transform_convert_gpencil.c

Loading...

source/blender/editors/transform/transform_convert_graph.c

Loading...

source/blender/editors/transform/transform_convert_object.c

Loading...

source/blender/editors/transform/transform_convert_object_texspace.c

Loading...

source/blender/editors/transform/transform_convert_particle.c

Loading...

source/blender/editors/transform/transform_convert_sculpt.c

Loading...

source/blender/editors/transform/transform_generics.c

Loading...

source/blender/editors/transform/transform_gizmo_3d.c

Loading...

source/blender/editors/transform/transform_orientations.c

Loading...

source/blender/editors/transform/transform_snap.c

Loading...

source/blender/editors/undo/ed_undo.c

Loading...

source/blender/editors/util/ed_util.c

Loading...

source/blender/makesdna/DNA_scene_types.h

Loading...

source/blender/makesrna/intern/rna_brush.c

Loading...

source/blender/makesrna/intern/rna_scene.c

Loading...

source/blender/makesrna/intern/rna_sculpt_paint.c

Loading...

source/blender/makesrna/intern/rna_space.c

Loading...

source/blender/nodes/geometry/node_geometry_tree.cc

Loading...

source/blender/nodes/shader/node_shader_tree.cc

Loading...

source/blender/nodes/texture/node_texture_tree.c

Loading...

source/blender/windowmanager/intern/wm_toolsystem.c

Loading...