It's indeed an annoying glitch, but I would solve it a bit differently since the idea of keeping the scroll offset might still be useful.
A better approach might be to change scroll offset so that the lowermost panel is at the lower view boundary, or that scroll offset is set to 0 if totrect is smaller than view boundaries. This way it's ensured that view is filled with as much content possible, without completely destroying previously set scroll offset.

This revision now requires changes to proceed.Oct 29 2015, 1:49 PM

Clamps the offset if it's too large, while preserving
it in other cases.

I totally forgot horizontal scrollbars in the last rev

Diego Gangl (januz) retitled this revision from Let scrollbars reset every time window contents change to Clamp scrollbar offset to lower view boundaries.Nov 1 2015, 12:18 AM

Diego Gangl (januz) updated this object.

Tested this again against master (A85F4571950). Surprisingly it still applies.
Everything seems to work correctly, it preserves the scroll when it can otherwise it resets.

Here's the blend file I use to test, the 2 suzannes have particles and the cube doesn't (scrollbar resets when clicking it)

scroll_test.blend233 KBDownload

This revision now requires changes to proceed.Apr 28 2017, 6:13 PM

Diego Gangl (januz) requested review of this revision.Apr 28 2017, 6:13 PM

Diego Gangl (januz) edited edge metadata.

Rebase against current master

(also friendly ping :) )

Aaron Carlisle (Blendify) added reviewers: Campbell Barton (campbellbarton), Bastien Montagne (mont29).Jan 9 2018, 4:12 PM

Pablo Vazquez (pablovazquez) awarded a token.Jan 10 2018, 3:44 PM

Ping!
Hey, this would be a great appetizer before the code quest :)

Am generally a bit wary of such changes in such vital functions, but think this is fine and worth trying. Only briefly tested though ;)

Oh but! Use tabs instead of spaces :P (Can change when committing myself)

source/blender/editors/screen/area.c
1900–1911	Looks like floating point precision checking? Would use `FLT_EPSILON` here.

This revision is now accepted and ready to land.Apr 8 2018, 5:17 PM

Use FLT_EPSILON for float presicion checking
Use tabs instead of spaces :)

All done!

In D1580#74549, @Julian Eisel (Severin) wrote:

Am generally a bit wary of such changes in such vital functions, but think this is fine and worth trying. Only briefly tested though ;)

This indeed touches very vital functions, but it tackles a very bad long-standing issue so I'd shovel it in 2.8 and test it until it's good! :D

Closed by commit rB7213553c84a3: UI: Clamp scrollbar offset to lower view boundaries (authored by Julian Eisel (Severin)). · Explain WhyApr 9 2018, 6:57 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) mentioned this in rB7213553c84a3: UI: Clamp scrollbar offset to lower view boundaries.

Aaand pushed. Thanks @Diego Gangl (januz)!

Awesome! Thanks for reviewing

Paweł Łyczkowski (plyczkowski) awarded a token.Apr 10 2018, 10:30 AM

Clamp scrollbar offset to lower view boundaries
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5350

source/blender/editors/screen/area.c

Clamp scrollbar offset to lower view boundariesClosedPublicActions