Page MenuHome
Differential D15810

Fix T93084: Area stretch overlay full red on large scale mesh
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 30 2022, 1:42 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Jeroen Bakker (jbakker)
Campbell Barton (campbellbarton)
Maniphest Tasks
T93084: blender uv stretch with area show full red (on large scale mesh)
Commits
rBf20d0de3b7b4: Fix T93084: Area stretch overlay full red on large scale mesh
Summary

Issue arises when face areas are really large combined with small UV
areas (report has a mesh ~1.5 km), then precission of shorts is
insufficient.

Now use floats instead.

NOTE: this is an alternative to D15805 (and quick tests show this does not introduce the tiny performance hit as D15805 did).

Diff Detail

Repository
rB Blender
Branch
T93084_b (branched from master)
Build Status
Buildable 23541
Build 23541: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 30 2022, 1:42 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B23540: Diff 55106.Aug 30 2022, 1:42 PM
Philipp Oeser (lichtwerk) mentioned this in D15805: Fix T93084: Area stretch overlay full red on large scale mesh.Aug 30 2022, 1:43 PM
Brecht Van Lommel (brecht) requested changes to this revision.Aug 30 2022, 1:55 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_stretch_area.cc
40

This can just be return uv_area / area; now.

47

This can be ratio * tot_ratio now, also in the GLSL code. inv_tot_ratio can be removed.

This revision now requires changes to proceed.Aug 30 2022, 1:55 PM
Brecht Van Lommel (brecht) added a comment.Aug 30 2022, 1:58 PM

The reason this inversion with the negative sign was done before was to fit things in the 0..1 range, that's no longer needed with float.

Philipp Oeser (lichtwerk) updated this revision to Diff 55107.Aug 30 2022, 2:18 PM

removed the negative signed version of the total area ratio (since with floats it is no longer used)
Thx Brecht for the hand-holding!

Harbormaster completed remote builds in B23541: Diff 55107.Aug 30 2022, 2:18 PM
Brecht Van Lommel (brecht) accepted this revision.Aug 30 2022, 3:08 PM
This revision is now accepted and ready to land.Aug 30 2022, 3:08 PM
Closed by commit rBf20d0de3b7b4: Fix T93084: Area stretch overlay full red on large scale mesh (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 30 2022, 8:20 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBf20d0de3b7b4: Fix T93084: Area stretch overlay full red on large scale mesh.
Jeroen Bakker (jbakker) awarded a token.Aug 30 2022, 10:55 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
overlay/
4 lines
1 line
shaders/
infos/
1 line
6 lines
intern/
mesh_extractors/
21 lines

Diff 55107

View Options

source/blender/draw/engines/overlay/overlay_edit_uv.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_private.h

Loading...
View Options

source/blender/draw/engines/overlay/shaders/infos/overlay_edit_mode_info.hh

Loading...
View Options

source/blender/draw/engines/overlay/shaders/overlay_edit_uv_stretching_vert.glsl

Loading...
View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_stretch_area.cc

Loading...