Page MenuHome

BLF: Incorrect Define Used
ClosedPublic

Authored by Harley Acheson (harley) on Aug 30 2022, 9:00 PM.

Details

Summary

Replace incorrect usage of GLYPH_ASCII_TABLE_SIZE with correct
KERNING_CACHE_TABLE_SIZE


I probably made this mistake years ago. We have one define - GLYPH_ASCII_TABLE_SIZE - which is used with our glyph cache, and another - KERNING_CACHE_TABLE_SIZE - which is used with our kerning cache. This patch corrects two instances of incorrect usage.

They both are the same value, 128, so this does not cause any real problems. However it is still an error. And I can can foresee proposed changes that would eliminate the glyph ascii table if we start hashing those by glyph index instead of by codepoint. I can also imagine changes to our kerning cache that could expand that to 65535.

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Aug 30 2022, 9:00 PM
Harley Acheson (harley) created this revision.

Too insignificant of an (own code) change to wait (any longer) for review.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2022, 6:58 PM
This revision was automatically updated to reflect the committed changes.