Also removes some code not being never executed ? or duplicated code
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/editors/transform/transform.c | ||
|---|---|---|
| 689 | This funcion is disabled, and it should be done reusing code. Removed. | |
| 969 | Was enablig/disabling MOD_PRESICION, now performed with TFM_MODAL_ENABLE_MOUSE_PRECISION and TFM_MODAL_DISABLE_MOUSE_PRECISION) | |
| 973 | ¿? Num Input is performed later | |
| 1277 | Removed all K_PRESS checks | |
| 1279 | TFM_MODAL_CANCEL | |
| 1285 | TFM_MODAL_MOUSE_PLANE_CONSTRAINT This setting was working on MIDDLEMOUSE KM_PRESS | |
| 1313 | TFM_MODAL_MOUSE_PLANE_CONSTRAINT | |
| 1318 | TFM_MODAL_MOUSE_AXIS_CONSTRAINT | |
| 1330 | TFM_MODAL_CANCEL | |
| 1335 | TFM_MODAL_CONFIRM | |
| 1339 | ALREADY PERFORMED CODE: TFM_MODAL_TRANSLATE | |
| 1351 | ALREADY PERFORMED CODE: TFM_MODAL_RESIZE | |
| 1363 | ALREADY PERFORMED CODE: TFM_MODAL_ROTATE | |
| 1384 | TFM_MODAL_SWITCH_PROP_CONNECTED | |
| 1393 | TFM_MODAL_STOP_CONSTRAINT | |
| 1401 | TFM_MODAL_AXIS_X | |
| 1402 | TFM_MODAL_AXIS_Y | |
| 1403 | TFM_MODAL_AXIS_Z | |
| 1409 | TFM_MODAL_CHANGE_PROP_MODE | |
| 1418 | TFM_MODAL_PROPSIZE_UP (who uses alt pad+ ?) | |
| 1439 | TFM_MODAL_PROPSIZE_DOWN (who uses alt pad- ?) | |
| 1447 | Not executed here TFM_MODAL_AUTOIK_LEN_DEC (with little diferences) | |
| 1452 | Was doing nothing (was disabled) | |
| 1458 | TFM_MODAL_SET_ALT_TRANSFORM | |
| 1475 | TFM_MODAL_MOUSE_PLANE_CONSTRAINT This setting was working on MIDDLEMOUSE KM_PRESS | |
| 1491 | TFM_MODAL_SET_RESET_TRANSFORM | |
| 1502 | can be removed? | |
| source/blender/editors/transform/transform_input.c | ||
| 421 | Removed managed on TFM_MODAL_ENABLE_MOUSE_PRECISION and TFM_MODAL_DISABLED_MOUSE_PRECISION | |
Comment Actions
This patch removes the ability to constrain to an axis (Shift+X/Y/Z for eg no longer work).
It seems you were aware of this since you mention it in T46610.
Are there other changes from the users perspective?
Please always include this kind of information on in the patch submission.
Otherwise we may review the code and commit it to master, without being aware of problems it introduces.
Work-in-progress patches are OK, just let us know there are unresolved issues they introduce.
| source/blender/editors/transform/transform.c | ||
|---|---|---|
| 1154 | The behavior was not accessing here. Was achieved setting MOD_CONSTRAINT_PLANE flag on SHIFT and checking the flag on transform_event_xyz_constraint. Same for plane[YZ] | |
Comment Actions
General +1 for transforming (pun!) these into modifiable keymap items. Didn't go over all details yet, but so far it looks mostly good to me, just some remarks.
@Bastien Montagne (mont29), @Sergey Sharybin (sergey), I definitely wouldn't commit such changes to transform code without having your green light for it, so adding you as reviewers.
| source/blender/editors/transform/transform.c | ||
|---|---|---|
| 689 | I'm fine with removing this, but would do in a separate patch/commit. | |
| 973 | Not sure on this change, there seems to be some reasoning on why this is how it is (also, see rBaef307cf31bee). I'd suggest we leave this out for now? | |
| 1502 | Hmm, release_confirm is broken here (e.g. visible using transform manipulators). This may be coming from the X11 keyrepeat bug mentioned below - an ugly bug that results in different behaviors on different X11 machines... | |
Comment Actions
Updated patch for latest master and minor code style corrections. Feel free to commandeer back @Jaume Bellet (mauge).