Fix T100747: Cannot add "String" attribute to mesh
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 2 2022, 12:00 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T100747: Regression: Cannot add "String" attribute to mesh

Commits

rB25c8d72e204b: Fix T100747: Cannot add "String" attribute to mesh

Summary

Caused by rB31365c6b9e4c: Attributes: Use new API for C-API functions.

The new API CustomDataAttributeProvider just did not support
CD_MASK_PROP_STRING...

If there are deeper reasons why this is not supported anymore, we should
remove it from the enum in the UI when adding a new attribute.

However, adding Strings to the supported types seems to survive just
fine, see attached example file.

T100747.blend830 KBDownload

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 2 2022, 12:00 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B23588: Diff 55230.Sep 2 2022, 12:00 PM

Philipp Oeser (lichtwerk) added projects: Modeling, Nodes & Physics.Sep 2 2022, 12:01 PM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)

Thanks for the patch. We haven't supported string attributes in geometry nodes yet because the way they're stored is very inefficient. At 256 bytes per element, they just don't scale at all.
However, sadly we can't just ignore their existence, since they've been exposed with the attribute API for a while. So exposing them in the attribute API but not geometry nodes seems fine to me for now.