- Remove "take ownership" argument which was confusing and always true
- The argument made ownership very confusing
- It's better to remove boolean arguments that switch a function's purpose
- Remove "mask" argument which was basically wrong and not used properly
- "EVERYTHING" was likely used because developers are wary of removing data
- Instead use CD_MASK_MESH for its purpose of original mesh data
- Remove use of shallow copied temporary mesh, which is unnecessary now
- Split some shape key processing into separate functions, use C++ types
- Copy fields explicitly rather than using memcpy for the whole struct
- Use higher level functions and avoid redundant logic
- The goal is pretty simple actually, and can be built from standard logic
- Adjust CustomData logic to be consistent with "assign" expectations
- Now it clears the layer data from the source, and moves the anonymous ID
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
To me it sounds and looks good. But would like if someone more familiar with the modelling module have a look as well.
Comment Actions
Regarding your questions: just keep the functionality from before.
| source/blender/blenkernel/intern/mesh_convert.cc | ||
|---|---|---|
| 1332 | typo (evaluation) | |
Comment Actions
- Merge master
- Split freeing animation data out of BKE_mesh_clear_geometry
- Formatting
- Rearrange code slightly
- Move vertex group name list instead of copying
- Fix typo
| source/blender/blenkernel/intern/mesh_convert.cc | ||
|---|---|---|
| 1276–1279 | This isn't used, for some reason it doesn't show as a compiler warning, assume it can be removed. | |