Fix T100649: Regression: Environment texture is stretched when added to mesh
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Sep 2 2022, 5:19 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Commits

rB3ae996c293ea: Fix T100649: Regression: Environment texture is stretched when added to mesh

Summary

The new code was not using the correct default attribute. Add access to
g_data.P through node_tex_coord_position() to replace the old
GPU_builtin(GPU_VIEW_POSITION) which was used before.

Diff Detail

Repository: rB Blender

Event Timeline

Clément Foucault (fclem) requested review of this revision.Sep 2 2022, 5:19 PM

Clément Foucault (fclem) created this revision.

Harbormaster completed remote builds in B23602: Diff 55252.Sep 2 2022, 5:19 PM

Jeroen Bakker (jbakker) accepted this revision.Sep 5 2022, 8:56 AM

This revision is now accepted and ready to land.Sep 5 2022, 8:56 AM

Closed by commit rB3ae996c293ea: Fix T100649: Regression: Environment texture is stretched when added to mesh (authored by Clément Foucault (fclem)). · Explain WhySep 5 2022, 9:21 AM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB3ae996c293ea: Fix T100649: Regression: Environment texture is stretched when added to mesh.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

material/

gpu_shader_material_texture_coordinates.glsl

5 lines

nodes/

shader/

nodes/

node_shader_tex_environment.cc

6 lines

Diff 55302

View Options

source/blender/gpu/shaders/material/gpu_shader_material_texture_coordinates.glsl