I tried a few different solutions and simplifications to the uses of the node_add_node
function, but I still don't understand the coordinate spaces apparently, because
this solution is the best I came up with.
This patch is against the 3.3 branch.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
With the suggested edit it seems good to me!
The socket location seems to be in view space, so dividing by UI_DPI_FAC brings them into the coordinate space of the node editor. This is consistent with what we're doing everywhere else with the cursor location before calling functions that add nodes.
The constant 100 x-offset for the node should already be in coordinate space though, so it does not have to be divided by UI_DPI_FAC anymore. Doing so means the offset of the viewer node varies depending on the UI Scale.
Here's the comparison:
| display / UI Scale | current patch | with inline comment |
| 1080p / 1.0 |  |  |
| 1080p / 2.0 |  |  |
| retina / 1.0 |  |  |
| retina / 2.0 |  |  |
| source/blender/editors/space_node/node_relationships.cc | ||
|---|---|---|
| 645 | ||