Differential D15879

Fix T100814: Cycles wrong area light parametric texture coordinates
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Sep 5 2022, 12:48 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T100814: Parametric doesn't generate UV correctly with area lights in 3.3 beta

Commits

rB1b216fc23707: Fix T100814: Cycles wrong area light parametric texture coordinates

Summary

The fix from cefd6140f322 was for light intersection, but light sampling also
needs it.

Diff Detail

Repository

rB Blender

Branch

blender-v3.3-release

Build Status

Buildable 23611
Build 23611: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Sep 5 2022, 12:48 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B23609: Diff 55304.Sep 5 2022, 12:48 PM

Philipp Oeser (lichtwerk) added a task: T100814: Parametric doesn't generate UV correctly with area lights in 3.3 beta.Sep 5 2022, 12:52 PM

Remove unrelated make format changes

Harbormaster completed remote builds in B23611: Diff 55307.Sep 5 2022, 1:26 PM

Sergey Sharybin (sergey) accepted this revision.Sep 5 2022, 2:59 PM

This revision is now accepted and ready to land.Sep 5 2022, 2:59 PM

Closed by commit rB1b216fc23707: Fix T100814: Cycles wrong area light parametric texture coordinates (authored by Brecht Van Lommel (brecht)). · Explain WhySep 5 2022, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB1b216fc23707: Fix T100814: Cycles wrong area light parametric texture coordinates.

Brecht Van Lommel (brecht) mentioned this in rBL63021: Tests: update area light UV test to handle both intersection and sampling.Sep 5 2022, 3:24 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

light/

light.h

8 lines

Diff 55307

View Options

intern/cycles/kernel/light/light.h

Fix T100814: Cycles wrong area light parametric texture coordinatesClosedPublicActions