Details

Reviewers

Maniphest Tasks

Commits

rBf017fdecefc4: ViewLayer: Reduce object duplication syncing

Summary

During object duplication the syncing is temporarily disabled.
With D15885: ViewLayer: Lazy sync of scene data. this isn't useful as when disabled the view_layer
is still accessed to locate bases. This can be improved by first
locating the source bases, then duplicate and sync and locate
the new bases.

This patch removes the resync forbid and improve the times
that resyncing actually must happen.

Diff Detail

Repository

rB Blender

Branch

temp-T73411-reduce-object-duplication-resyncing (branched from master)

Build Status

Buildable 24276
Build 24276: arc lint + arc unit

Event Timeline

Monique Dewanchand (mdewanchand) requested review of this revision.Sep 5 2022, 9:38 PM

Monique Dewanchand (mdewanchand) created this revision.

Monique Dewanchand (mdewanchand) added a parent revision: D15885: ViewLayer: Lazy sync of scene data..

Monique Dewanchand (mdewanchand) mentioned this in D15885: ViewLayer: Lazy sync of scene data..

Monique Dewanchand (mdewanchand) added a task: T73411: Fix ViewLayers cache building.

Aras Pranckevicius (aras_p) added a subscriber: Aras Pranckevicius (aras_p).Sep 6 2022, 6:11 AM

monique (monique) mentioned this in rB68589a31ebfb: ViewLayer: Lazy sync of scene data..Sep 14 2022, 9:36 PM

Updated to latest master.
Fails when used.

Harbormaster completed remote builds in B23771: Diff 55729.Sep 15 2022, 9:01 AM

Fix crash as syncing was still disabled.

Harbormaster completed remote builds in B23772: Diff 55730.Sep 15 2022, 9:10 AM

Monique Dewanchand (mdewanchand) retitled this revision from [WIP] ViewLayer: Reduce object duplication syncing to ViewLayer: Reduce object duplication syncing.Sep 15 2022, 9:12 AM

Monique Dewanchand (mdewanchand) edited the summary of this revision. (Show Details)

Minor notes below, otherwise looks good to me.

source/blender/editors/object/object_add.cc
3729	Think this call should be done once outside of the loop, and its result stored in a variable?
3739–3758	Don't think that last loop is needed, afaics its content can be put into the previous loop ?
3752–3754	why not just `link.object_new` here?