Page MenuHome
Differential D15893

Fix T100851: Sync markers does not work for numinput
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 6 2022, 1:10 PM.

Details

Reviewers
Germano Cavalcante (mano-wii)
Maniphest Tasks
T100851: Sync markers option doesn't work when sliding keyframes with a keyboard entry
Commits
rB0a3b6b134c7e: Fix T100851: Sync markers does not work for numinput
rB8c148a4f3b8f: Fix T100851: Sync markers does not work for numinput
rB6d0f8d5a19c8: Fix T100851: Sync markers does not work for numinput
Summary

special_aftertrans_update would use the always use TransInfo values (not
the values_final -- this is where numinput ends up it seems)

Diff Detail

Repository
rB Blender
Branch
T100851 (branched from master)
Build Status
Buildable 23630
Build 23630: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 6 2022, 1:10 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B23630: Diff 55350.Sep 6 2022, 1:10 PM
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, VFX & Video, Modeling.Sep 6 2022, 1:11 PM
Germano Cavalcante (mano-wii) added a comment.Sep 6 2022, 2:05 PM

I feel that only t->values_final should be used here.
t->values is the position calculated with the mouse only (useful for redo operations).
t->values_final is the final transformation, t->values + constrain + snapping + input...

If markers must always follow the final transformation, they must use t->values_final.

Philipp Oeser (lichtwerk) added a comment.Sep 6 2022, 2:32 PM
In D15893#431686, @Germano Cavalcante (mano-wii) wrote:

I feel that only t->values_final should be used here.
t->values is the position calculated with the mouse only (useful for redo operations).
t->values_final is the final transformation, t->values + constrain + snapping + input...

If markers must always follow the final transformation, they must use t->values_final.

Sounds very reasonable, will check and update in a bit

Philipp Oeser (lichtwerk) updated this revision to Diff 55429.Sep 8 2022, 9:23 AM

always use values_final

Harbormaster completed remote builds in B23661: Diff 55429.Sep 8 2022, 9:24 AM
Germano Cavalcante (mano-wii) accepted this revision.Sep 10 2022, 4:35 PM
This revision is now accepted and ready to land.Sep 10 2022, 4:35 PM
Closed by commit rB6d0f8d5a19c8: Fix T100851: Sync markers does not work for numinput (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 12 2022, 9:12 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB6d0f8d5a19c8: Fix T100851: Sync markers does not work for numinput.
Philipp Oeser (lichtwerk) added a commit: rB8c148a4f3b8f: Fix T100851: Sync markers does not work for numinput.Sep 19 2022, 2:54 PM
Philipp Oeser (lichtwerk) added a commit: rB0a3b6b134c7e: Fix T100851: Sync markers does not work for numinput.Sep 21 2022, 2:28 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
7 lines
5 lines

Diff 55350

View Options

source/blender/editors/transform/transform_convert_action.c

Loading...
View Options

source/blender/editors/transform/transform_convert_sequencer.c

Loading...