Page MenuHome
Differential D158

BGE: Remove old world bge.render API
ClosedPublic
Actions

Authored by Thomas Szepe (hg1) on Dec 29 2013, 4:41 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Mitchell Stokes (moguri)
Commits
rBSee579684617c: BGE: Remove old world bge.render API
rBee579684617c: BGE: Remove old world bge.render API
Summary

This patch can be used to remove the old world bge.render API if the new world API D157 is used.

If the new world API is applied we can remove the old API because the old has newer worked.
The patch keep the two old working methods for backward compatibility.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) added a comment.Dec 31 2013, 1:12 AM

Same comment as D157, code looks ok but it's not my decision.

Thomas Szepe (hg1) updated this revision to Unknown Object (????).Jan 8 2014, 11:41 PM

Update necessary about the other patch changes.

Mitchell Stokes (moguri) requested changes to this revision.Apr 16 2014, 4:46 AM

As mentioned in D157, you should print deprecation warnings for deprecated functions. As for removing the not working functions, I am okay with this, but it would be best to have Campbell give a final okay.

Mitchell Stokes (moguri) added a reviewer: Campbell Barton (campbellbarton).Apr 16 2014, 4:47 AM
Thomas Szepe (hg1) updated this revision to Unknown Object (????).Jul 19 2014, 7:30 PM

Update for the actual master.

Campbell Barton (campbellbarton) accepted this revision.Feb 2 2015, 3:30 PM
Campbell Barton (campbellbarton) edited edge metadata.

Needs updating, but think its fine to go in.

This revision now requires changes to proceed.Feb 2 2015, 3:30 PM
Thomas Szepe (hg1) updated this revision to Diff 3524.Feb 14 2015, 4:35 PM
Thomas Szepe (hg1) edited edge metadata.

Update fix merge conflicts with actual master branch.

Mitchell Stokes (moguri) accepted this revision.Feb 24 2015, 8:10 PM
Mitchell Stokes (moguri) edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 8:10 PM
Thomas Szepe (hg1) mentioned this in T43822: Videotexture does not use sky color for off-screen rendering.Feb 28 2015, 12:15 PM
Closed by commit rBee579684617c: BGE: Remove old world bge.render API (authored by Thomas Szepe (hg1)). · Explain WhyMar 24 2015, 12:28 AM
This revision was automatically updated to reflect the committed changes.
Thomas Szepe (hg1) mentioned this in D155: BGE: Add new get methods for world values.Mar 24 2015, 12:33 AM

Revision Contents
Changeset List

PathSize
doc/
python_api/
rst/
70 lines
source/
gameengine/
Ketsji/
159 lines
14 lines
70 lines

Diff 3823

View Options

doc/python_api/rst/bge.render.rst

Loading...
View Options

source/gameengine/Ketsji/KX_PythonInit.cpp

Loading...
View Options

source/gameengine/Ketsji/KX_WorldInfo.h

Loading...
View Options

source/gameengine/Ketsji/KX_WorldInfo.cpp

Loading...