Differential D15920

Fix T100521: Node doesn't belong to frame when added through link drag search (Version 2)
ClosedPublic
Actions

Authored by Dominik Fill (dominikfill) on Sep 8 2022, 10:17 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Group Reviewers

User Interface

Commits

rB4a71765f9a41: Fix T100521: Nodes added with link drag search not added to frame

Summary

Alternative fix for T100521
Continued from D15888.

Use macro NODE_OT_translate_attach for attaching node created through link-drag-search to frame, as suggested by @Leon Schittek (lone_noel) in D15888.

Created a new diff as I somehow created a mess with branches and it wouldn't let me update the old diff.

Diff Detail

Repository: rB Blender

Event Timeline

Dominik Fill (dominikfill) requested review of this revision.Sep 8 2022, 10:17 PM

Dominik Fill (dominikfill) created this revision.

Harbormaster completed remote builds in B23675: Diff 55459.Sep 8 2022, 10:17 PM

Dominik Fill (dominikfill) changed the edit policy from "All Users" to "No One".Sep 8 2022, 10:17 PM

Dominik Fill (dominikfill) changed the visibility from "Public (No Login Required)" to "No One".

Dominik Fill (dominikfill) changed the edit policy from "No One" to "All Users".

Dominik Fill (dominikfill) retitled this revision from use macro NODE_OT_translate_attach for attaching node created through link-drag-search to Fix T100521: Node doesn't belong to frame when added through link drag search (Version 2).Sep 8 2022, 10:23 PM

Dominik Fill (dominikfill) edited the summary of this revision. (Show Details)

Dominik Fill (dominikfill) added a reviewer: User Interface.

Dominik Fill (dominikfill) changed the visibility from "No One" to "Public (No Login Required)".

Dominik Fill (dominikfill) mentioned this in D15888: Fix T100521: Node doesn't belong to frame when added through link drag search.Sep 8 2022, 10:25 PM

Dominik Fill (dominikfill) edited the summary of this revision. (Show Details)Sep 8 2022, 10:32 PM

Dominik Fill (dominikfill) added a subscriber: Leon Schittek (lone_noel).

Hans Goudey (HooglyBoogly) accepted this revision.Sep 9 2022, 12:01 AM

This revision is now accepted and ready to land.Sep 9 2022, 12:01 AM

Closed by commit rB4a71765f9a41: Fix T100521: Nodes added with link drag search not added to frame (authored by Dominik Fill (dominikfill), committed by Hans Goudey (HooglyBoogly)). · Explain WhySep 9 2022, 12:06 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB4a71765f9a41: Fix T100521: Nodes added with link drag search not added to frame.