Paths

Table of Contentst

Differential D15938

I18n: disambiguate and extract a few messages
ClosedPublic
Actions

Authored by Damien Picard (pioverfour) on Sep 11 2022, 7:48 PM.

Tags

Subscribers

Jacques Lucke (JacquesLucke)

Details

Reviewers

Bastien Montagne (mont29)

Commits

rBa869fcd686f4: I18n: disambiguate and extract a few messages

Summary

Disambiguate:

Lower / Upper (case)
Spray (ocean modifier)
Keep Original (clip, grease pencil, object)
Screen [space] (inside some enum items, mostly)
Cast Shadow ("shadow that is cast", not "to cast a shadow")

Extract:

Line Art Light Reference Near and Far
Mesh vertex attribute domain: Vertex

Diff Detail

Repository: rB Blender

Event Timeline

Damien Picard (pioverfour) requested review of this revision.Sep 11 2022, 7:48 PM

Damien Picard (pioverfour) created this revision.

Damien Picard (pioverfour) added a subscriber: Jacques Lucke (JacquesLucke).Sep 11 2022, 7:55 PM

Damien Picard (pioverfour) added inline comments.

source/blender/makesrna/intern/rna_attribute.c
199	The message extraction does not work when the `EnumPropertyItem` is `static`, but as far as I could find, it’s the only occurrence of this in the code base. @Jacques Lucke (JacquesLucke) Is it acceptable to make it not `static`? If not, what can be done about it?

Bastien Montagne (mont29) requested changes to this revision.Sep 13 2022, 12:36 PM

Bastien Montagne (mont29) added inline comments.

source/blender/makesrna/intern/rna_attribute.c
199	I indeed do not see any reason for this to be static, since `RNA_enum_item_add` does not keep any reference to the given item, but copies its value. unless am missing something @Jacques Lucke (JacquesLucke) ?
200	These should not be actual translation here? so rather use the `N_` marker macro.

This revision now requires changes to proceed.Sep 13 2022, 12:36 PM

Jacques Lucke (JacquesLucke) added inline comments.Sep 13 2022, 12:46 PM

source/blender/makesrna/intern/rna_attribute.c
199	Removing static here should be fine. I think it makes sense for this to be static, but if that doesn't work with I18n, that's fine too.

Replace actual translations by message extractions

Bastien Montagne (mont29) added inline comments.Sep 14 2022, 10:37 AM

source/blender/makesrna/intern/rna_attribute.c
199	Actually now that they are just marked for translation, and not actually translated, it should be fine to keep this static.

Reintroduce static EnumPropertyItem

Bastien Montagne (mont29) accepted this revision.Sep 15 2022, 11:12 AM

This revision is now accepted and ready to land.Sep 15 2022, 11:12 AM

Closed by commit rBa869fcd686f4: I18n: disambiguate and extract a few messages (authored by Damien Picard (pioverfour), committed by Bastien Montagne (mont29)). · Explain WhySep 15 2022, 11:39 AM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rBa869fcd686f4: I18n: disambiguate and extract a few messages.

Damien Picard (pioverfour) mentioned this in T43295: Translation disambiguation requests.Sep 16 2022, 9:17 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

curve/

7 lines

gpencil/

4 lines

mesh/

editmesh_knife.c

3 lines

object/

11 lines

space_clip/

1 line

gpencil_modifiers/

intern/

MOD_gpencillineart.c

6 lines

makesrna/

intern/

rna_attribute.c

4 lines

rna_sequencer.c

1 line

1 line

1 line

modifiers/

intern/

2 lines

Diff 55733

source/blender/editors/curve/editfont.c

Loading...

source/blender/editors/gpencil/gpencil_edit.c

Loading...

source/blender/editors/mesh/editmesh_knife.c

Loading...

source/blender/editors/object/object_add.cc

Loading...

source/blender/editors/space_clip/tracking_ops.c

Loading...

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

Loading...

source/blender/makesrna/intern/rna_attribute.c

Loading...

source/blender/makesrna/intern/rna_sequencer.c

Loading...

source/blender/makesrna/intern/rna_space.c

Loading...

source/blender/makesrna/intern/rna_wm.c

Loading...

source/blender/modifiers/intern/MOD_ocean.c

Loading...