Page MenuHome
Differential D15953

Metal: MTLContext implementation and immediate mode rendering support.
ClosedPublic
Actions

Authored by Thomas Dinges (dingto) on Sep 13 2022, 9:53 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T96261: Metal Viewport
Commits
rB697b447c2069: Metal: MTLContext implementation and immediate mode rendering support.
Summary

Metal: MTLContext implementation and immediate mode rendering support.

MTLContext provides functionality for command encoding, binding management and graphics device management. MTLImmediate provides simple draw enablement with dynamically encoded data. These draws utilise temporary scratch buffer memory to provide minimal bandwidth overhead during workload submission.

This patch also contains empty placeholders for MTLBatch and MTLDrawList to enable testing of first pixels on-screen without failure.

The Metal API also requires access to the GHOST_Context to ensure the same pre-initialized Metal GPU device is used by the viewport. Given the explicit nature of Metal, explicit control is also needed over presentation, to ensure correct work scheduling and rendering pipeline state.

Authored by Apple: Michael Parkin-White

Ref T96261

(The diff is based on 043f59cb3b5835ba1a0bbf6f1cbad080b527f7f6)

Diff Detail

Repository
rB Blender

Event Timeline

Thomas Dinges (dingto) requested review of this revision.Sep 13 2022, 9:53 AM
Thomas Dinges (dingto) created this revision.
Clément Foucault (fclem) requested changes to this revision.Sep 15 2022, 12:46 PM

Small nitpicks, otherwise looks good.

source/blender/gpu/intern/gpu_shader_interface.cc
25–27

Use MEM_SAFE_FREE

source/blender/gpu/metal/mtl_context.hh
582

Use int64_t instead. Applies to all the PR.

source/blender/gpu/metal/mtl_context.mm
147

Left over printf

This revision now requires changes to proceed.Sep 15 2022, 12:46 PM
Michael Parkin-White (MichaelPW) added a comment.Sep 20 2022, 3:39 PM

Thanks for the feedback @Clément Foucault (fclem)! Will address this shortly. Please note that this patch also contains the mtl_vertex_buffer.hh/mtl_vertex_buffer.mm* changes from https://developer.blender.org/D15452 as they were required as a pre-requisite.
D15452 should be merged first however.

Jason Fielder (jason_apple) updated this revision to Diff 55964.Sep 21 2022, 2:54 PM

DIFF feedback addressed.

Harbormaster completed remote builds in B23869: Diff 55964.Sep 21 2022, 2:54 PM
Clément Foucault (fclem) accepted this revision.Sep 22 2022, 5:20 PM
This revision is now accepted and ready to land.Sep 22 2022, 5:20 PM
Closed by commit rB697b447c2069: Metal: MTLContext implementation and immediate mode rendering support. (authored by Thomas Dinges (dingto), committed by Clément Foucault (fclem)). · Explain WhySep 22 2022, 5:35 PM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rB697b447c2069: Metal: MTLContext implementation and immediate mode rendering support..
Brecht Van Lommel (brecht) mentioned this in T103479: Laucnh error since version 3.4.Jan 5 2023, 6:36 PM

Revision Contents
Changeset List

PathSize
intern/
ghost/
intern/
8 lines
79 lines
805 lines
74 lines
5 lines
test/
multitest/
6 lines
source/
blender/
draw/
1 line
engines/
eevee/
2 lines
eevee_next/
2 lines
intern/
1 line
2 lines
194 lines
gpu/
4 lines
2 lines
25 lines
intern/
2 lines
4 lines
101 lines
7 lines
215 lines
15 lines
19 lines
2 lines
4 lines
metal/
2 lines
15 lines
41 lines
172 lines
4 lines
132 lines
1191 lines
34 lines
41 lines
397 lines
6 lines
2 lines
27 lines
4 lines
89 lines
30 lines
opengl/
2 lines
tests/
2 lines
render/
intern/
2 lines
windowmanager/
intern/
2 lines
2 lines

Diff 56012

View Options

intern/ghost/intern/GHOST_Context.h

Loading...
View Options

intern/ghost/intern/GHOST_ContextCGL.h

Loading...
View Options

intern/ghost/intern/GHOST_ContextCGL.mm

Loading...
View Options

intern/ghost/intern/GHOST_Window.h

Loading...
View Options

intern/ghost/intern/GHOST_Window.cpp

Loading...
View Options

intern/ghost/test/multitest/MultiTest.c

Loading...
View Options

source/blender/draw/DRW_engine.h

Loading...
View Options

source/blender/draw/engines/eevee/eevee_lightcache.c

Loading...
View Options

source/blender/draw/engines/eevee_next/eevee_shader.cc

Loading...
View Options

source/blender/draw/intern/DRW_render.h

Loading...
View Options

source/blender/draw/intern/draw_manager.c

Loading...
View Options

source/blender/draw/intern/draw_manager_shader.c

Loading...
View Options

source/blender/gpu/CMakeLists.txt

Loading...
View Options

source/blender/gpu/GPU_context.h

Loading...
View Options

source/blender/gpu/GPU_material.h

Loading...
View Options

source/blender/gpu/intern/gpu_backend.hh

Loading...
View Options

source/blender/gpu/intern/gpu_codegen.h

Loading...
View Options

source/blender/gpu/intern/gpu_codegen.cc

Loading...
View Options

source/blender/gpu/intern/gpu_context.cc

Loading...
View Options

source/blender/gpu/intern/gpu_material.c

Loading...
View Options

source/blender/gpu/intern/gpu_node_graph.h

Loading...
View Options

source/blender/gpu/intern/gpu_node_graph.c

Loading...
View Options

source/blender/gpu/intern/gpu_shader_builder.cc

Loading...
View Options

source/blender/gpu/intern/gpu_shader_interface.cc

Loading...
View Options

source/blender/gpu/metal/mtl_backend.hh

Loading...
View Options

source/blender/gpu/metal/mtl_backend.mm

Loading...
View Options

source/blender/gpu/metal/mtl_batch.hh

Loading...
View Options

source/blender/gpu/metal/mtl_command_buffer.mm

Loading...
View Options

source/blender/gpu/metal/mtl_common.hh

Loading...
View Options

source/blender/gpu/metal/mtl_context.hh

Loading...
View Options

source/blender/gpu/metal/mtl_context.mm

Loading...
View Options

source/blender/gpu/metal/mtl_drawlist.hh

Loading...
View Options

source/blender/gpu/metal/mtl_immediate.hh

Loading...
View Options

source/blender/gpu/metal/mtl_immediate.mm

Loading...
View Options

source/blender/gpu/metal/mtl_memory.hh

Loading...
View Options

source/blender/gpu/metal/mtl_shader.hh

Loading...
View Options

source/blender/gpu/metal/mtl_shader.mm

Loading...
View Options

source/blender/gpu/metal/mtl_shader_generator.mm

Loading...
View Options

source/blender/gpu/metal/mtl_texture.mm

Loading...
View Options

source/blender/gpu/metal/mtl_texture_util.mm

Loading...
View Options

source/blender/gpu/opengl/gl_backend.hh

Loading...
View Options

source/blender/gpu/tests/gpu_testing.cc

Loading...
View Options

source/blender/render/intern/pipeline.cc

Loading...
View Options

source/blender/windowmanager/intern/wm_playanim.c

Loading...
View Options

source/blender/windowmanager/intern/wm_window.c

Loading...