The users had to type in a name here, but we can also make it a dropdown
choice with existing UV Maps for convenience:
- dont have to remember a name or copy paste obviously
- shows in red if it was removed / invalid
Came up in T101028
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| release/scripts/startup/bl_ui/properties_data_curves.py | ||
|---|---|---|
| 48 | I think the property should always be visible. Just maybe grayed out when no surface is set. | |
Comment Actions
Will we still be able to type the name of a generic float2 attribute here? Or maybe we should just ignore that since D14365 is the solution?
Comment Actions
Yeah, think we can ignore that for now. The attribute on the original data can always be converted if necessary.
| release/scripts/startup/bl_ui/properties_data_curves.py | ||
|---|---|---|
| 48 | Not sure, we usually hide prop_search if the data to search from is not available? | |
| release/scripts/startup/bl_ui/properties_data_curves.py | ||
|---|---|---|
| 48 | Do you have examples? | |
| release/scripts/startup/bl_ui/properties_data_curves.py | ||
|---|---|---|
| 48 | I disagree. We usually just gray out properties if they don't have an effect. This is more intuitive since you don't "lose" things in the UI-- instead the fact that they don't work is explicit. | |
| release/scripts/startup/bl_ui/properties_data_curves.py | ||
|---|---|---|
| 48 | Really dont have a strong opinion here, but searching for .prop_search(in the Proerties Editor gives a couple of examples that are conditional (preceeded by if-checking the existance of the data we are searching from) | |
Comment Actions
Soo... have you checked on the cases in the Properties Editor? (constraints subtargets etc.).
While not a 1:1 match (these often also check the type of data we are searching from -- but also checking the existance in the first place).
Anyways, will update the patch to have it show grayed out.
| release/scripts/startup/bl_ui/properties_data_curves.py | ||
|---|---|---|
| 47–54 | Any reason not to do it simpler like this? | |
Comment Actions
Afk atm. but doesnt prop_search print errors to the console if ob.data.surface.data is None?