Page MenuHome
Differential D15969

Fix T101046: missing DEG update changing bone layers in editmode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 14 2022, 1:17 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T101046: Moving bone to another layer doesn't trigger a depsgraph update
Commits
rB3dce2469eea5: Fix T101046: missing DEG update changing bone layers in editmode
rB0ecc1d788cb9: Fix T101046: missing DEG update changing bone layers in editmode
rBc350d97a2f69: Fix T101046: missing DEG update changing bone layers in editmode
Summary

Following T54811: COW Operators: Edit Armature (and rBbb92edd1c802: Depsgraph: Keep edit bones around, fixes missing edit mode with copy on write), DEG updates have been added
to the various operators. This has also been done for the layers
operators (see rBf998bad211ae: Fix: Last of the operators from T54811 now work with Copy on Write, ARMATURE_OT_bone_layers has been
marked done in T54811). However, instead of ARMATURE_OT_bone_layers,
the update tagging actually happened for POSE_OT_bone_layers.

Now do this for ARMATURE_OT_bone_layers as well (keep it for
POSE_OT_bone_layers, dont think this is wrong there either).

Diff Detail

Repository
rB Blender
Branch
T101046 (branched from master)
Build Status
Buildable 23898
Build 23898: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 14 2022, 1:17 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B23751: Diff 55676.Sep 14 2022, 1:17 PM
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, Dependency Graph.Sep 14 2022, 1:17 PM
Sergey Sharybin (sergey) added a comment.Sep 14 2022, 2:45 PM

Generally makes sense, but i'd use ID_RECALC_PARAMETERS which seems to be closer to semantic meaning of what is being changed.

Tony Reason (drpontchartrain) awarded a token.Sep 15 2022, 3:07 AM
Philipp Oeser (lichtwerk) updated this revision to Diff 56035.Sep 23 2022, 10:09 AM
  • use ID_RECALC_PARAMETERS
Harbormaster completed remote builds in B23898: Diff 56035.Sep 23 2022, 10:09 AM
Sergey Sharybin (sergey) accepted this revision.Sep 23 2022, 10:30 AM
This revision is now accepted and ready to land.Sep 23 2022, 10:30 AM
Closed by commit rBc350d97a2f69: Fix T101046: missing DEG update changing bone layers in editmode (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 23 2022, 12:09 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBc350d97a2f69: Fix T101046: missing DEG update changing bone layers in editmode.
Philipp Oeser (lichtwerk) added a commit: rB0ecc1d788cb9: Fix T101046: missing DEG update changing bone layers in editmode.Sep 30 2022, 2:40 PM
Philipp Oeser (lichtwerk) added a commit: rB3dce2469eea5: Fix T101046: missing DEG update changing bone layers in editmode.Oct 3 2022, 9:25 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
armature/
1 line

Diff 56035

View Options

source/blender/editors/armature/pose_edit.c

Loading...