Fix: Respect users' choise of RGB for EXR
ClosedPublic
Actions

Authored by Lin Hsu (linhsu0723) on Sep 15 2022, 7:12 PM.

Details

Reviewers

Commits

rBe2572bd89f14: Fix OpenEXR saving still outputting alpha when using RGB instead of RGBA mode

Summary

Currently RGBA is used even RGB is chosen for EXR. This causes different
image appearances in other image viewers if not all alpha values are 0.

Diff Detail

Repository: rB Blender

Event Timeline

Lin Hsu (linhsu0723) requested review of this revision.Sep 15 2022, 7:12 PM

Lin Hsu (linhsu0723) created this revision.

Harbormaster completed remote builds in B23788: Diff 55750.Sep 15 2022, 7:12 PM

Lin Hsu (linhsu0723) added a reviewer: Brecht Van Lommel (brecht).Sep 15 2022, 9:34 PM

I'll commit this, but will also in a separate commit disable the BW/RGB/RGBA option for multilayer OpenEXR and leave it only for OpenEXR.

Saving some render passes as RGB instead of RGBA can break in unexpected ways (e.g. for cryptomatte), and in general multilayer is intended to dump the raw render for further processing.

This revision is now accepted and ready to land.Oct 3 2022, 9:03 PM

Closed by commit rBe2572bd89f14: Fix OpenEXR saving still outputting alpha when using RGB instead of RGBA mode (authored by Brecht Van Lommel (brecht)). · Explain WhyOct 3 2022, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBe2572bd89f14: Fix OpenEXR saving still outputting alpha when using RGB instead of RGBA mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

image_save.cc

8 lines

Diff 56411

View Options

source/blender/blenkernel/intern/image_save.cc

Fix: Respect users' choise of RGB for EXRClosedPublicActions