Details

Reviewers

Sybren A. Stüvel (sybren)
Dennis Brown (DBrown)

Group Reviewers

Documentation

Summary

The Camera Depth of Field Panel (Cycles) options added, and written with the new writing style. Also, a Bokeh example image added to show the effect. Followed current "camera" file naming convention, until entire section is migrated over.

New BI Panel image. I wasn't sure if there was a way to update this with a diff, so I just uploaded below with an added tag (-new). Docs still point to camera-dof-panel.jpg

*Images Updated with new Names*

cycles-camera-dof-bokeh.jpg

cycles-camera-dof-panel.jpg

camera-dof-panel-new.jpg

camera-dof-bokeh.jpg

Diff Detail

Event Timeline

Dennis Brown (DBrown) updated this revision to Diff 5351.Nov 1 2015, 5:52 AM

Dennis Brown (DBrown) retitled this revision from to Camera Depth of Field Panel (Cycles Render Engine).

Dennis Brown (DBrown) updated this object.

Dennis Brown (DBrown) added a reviewer: Documentation.

Dennis Brown (DBrown) set the repository for this revision to rBM Blender Manual.

There are a few things that should be clarified. Right now the documentation states little more than just the tooltips from Blender, which adds little to what's already available to users. I've added inline comments to explain what's missing.

Some sentences don't end with a period. Please write correct English.

manual/render/camera/introduction.rst
148	Maybe add a sentence to explain that the position of the object doesn't matter that much, but only the distance to the camera is important? Also see my note at the 'distance' property. Then again, maybe position is important once you start tilting the lens? It may be nice to explain this in the documentation.
151	A camera has a focal plane, not a focal point.
154	What sets it apart from the "not high quality"? Why would someone not want high quality?
163	You can't use both, you can either one or the other. Furthermore, I don't think you set it for the render/preview, but for the camera. Of course you can describe that both the render and the preview use the DoF settings, but that's a separate sentence. Also it feels more like a sentence that belongs to an introduction, and not this list of properties.
166	Please add something like "depending on your choce at .,,", so that the reader knows why you mention two different things in the same sentence.
175	As a part-time professional photographer, I have no idea what "the aperture effect" is, so it's doubtful that other people understand this. Since the "amount of blur" is a concept already used, "aperture effect" must refer to something else, and then there is "distortion" which also hasn't been used so far. Even the tooltip specifies "anamorphic lens bokeh", which makes it much more concrete.

This revision now requires changes to proceed.Nov 1 2015, 11:12 AM

I thought I added more than the tooltips, but I was also trying to keep from going overboard. I'll add more clarity to the options, and update the revision.

Don't worry about that. More than one line of explanation is far from going overboard ;-)

Here we go, a much better result than before. This should clear up any uncertainty, or questions about these features, as well as provide as an easy to read section.

Crap. Another revision incoming. Just noticed some issues.

Ok, there we go. Fixed.

Of course. I just now see your notes. Will probably result in another revision.....

Redundancies removed, clarity added, and simple descriptions. Covered each function in detail, so that the option was clear to a new user.

This is great documentation, thanks!

This revision is now accepted and ready to land.Nov 1 2015, 9:33 PM

Thank you. I'm glad to have helped.

manual/render/camera/introduction.rst
151	Correct, and why I worded it this way. Instead of making users wonder what a focal plane is, I'm referring to the point shown in the limits display, which is simply a point in the 3D space. My revised version may make more sense. I'm not even making sense of this first revision I made late last night.
154	Yes, will rewrite this again.
163	This was corrected in the 2nd revision.
166	Yes, did cover this in short detail.

The specific settings to the render IMO should be split up into the BI rendering docs and the Cycles rendering docs. While the settings that are shared kept in this doc.

This revision now requires changes to proceed.Nov 2 2015, 2:09 AM

Ah, right. Absolutely. That is my fault. I was quite confused by the layout, and was apparently in the BI. I'm not sure how I didn't notice before. Yes, the picture was straight from Cycles, so it does not belong in BI at all. My apologizes, I thought it was an "overall" page. I'll create a new diff, with the correct page altered, but I will also make sure to update the BI side as well, while I'm at it.

Good save!

Dennis Brown (DBrown) updated this revision to Diff 5368.Nov 2 2015, 5:10 AM

Dennis Brown (DBrown) updated this object.

Dennis Brown (DBrown) edited edge metadata.

A few little annoyances with the referenced images resolved.

Looks good however I can not get the patch to apply with my particular SVN Client can someone else do this? @Campbell Barton (campbellbarton) @Kitt Zwovic (gandalf3) ?

manual/render/camera/introduction.rst
108	Title needs to be fixed

This revision is now accepted and ready to land.Nov 2 2015, 8:24 PM

After wondering why the patch wouldn't apply, I saw that it was already committed by @Kitt Zwovic (gandalf3). Apparently this isn't reflected on Differential automatically.

Aaron Carlisle (Blendify) commandeered this revision.Nov 3 2015, 2:30 PM

Aaron Carlisle (Blendify) abandoned this revision.

Aaron Carlisle (Blendify) edited reviewers, added: Dennis Brown (DBrown); removed: Aaron Carlisle (Blendify).

It's supposed to auto-close this revision when committed, but for some reason it sometimes doesn't work..

Autoclose of revisions works if you include "Differential Revision: https://developer.blender.org/D1599" in the commit. If you use arc that happens automatically, otherwise you would need to add that text to the commit log manually.

Is it case-sensitive? I wrote "Differential revision: https://developer.blender.org/D1599" in the commit (rBM877), but no dice..

I haven't been able to get arc to work either :/

I don't know if it's case sensitive. Perhaps it shouldn't be the first line in the commit, normally that's a one line description of the commit contents.

Camera Depth of Field Panel (Cycles Render Engine)
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5370

.

manual/images/camera-dof-bokeh.jpg

manual/images/cycles-camera-dof-bokeh.jpg

manual/images/cycles-camera-dof-panel.jpg

manual/render/camera/introduction.rst

manual/render/cycles/camera.rst

Camera Depth of Field Panel (Cycles Render Engine)AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5370

.

manual/images/camera-dof-bokeh.jpg

manual/images/cycles-camera-dof-bokeh.jpg

manual/images/cycles-camera-dof-panel.jpg

manual/render/camera/introduction.rst

manual/render/cycles/camera.rst

Camera Depth of Field Panel (Cycles Render Engine)
AbandonedPublic
Actions

Revision Contents
Changeset List