Differential D16002

Fix T101137: Crash with Transform Node
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Sep 18 2022, 12:00 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T101137: Regression: Crash on connecting UV sphere node to transform node

Commits

rB9b591a104b35: Fix T101137: Crash with Transform Node
rB8a9f6a2e0a15: Fix T101137: Crash with Transform Node

Summary

In BKE_mesh_tag_coords_changed_uniformly the checks for dirty vertex and
dirty poly normals were swapped around, causing an assert to be
triggered.

Diff Detail

Repository

rB Blender

Branch

dirty_normals_bug (branched from master)

Build Status

Buildable 23818
Build 23818: arc lint + arc unit

Event Timeline

Wannes Malfait (Wannes) requested review of this revision.Sep 18 2022, 12:00 PM

Wannes Malfait (Wannes) created this revision.

Harbormaster completed remote builds in B23818: Diff 55824.Sep 18 2022, 12:00 PM

Wannes Malfait (Wannes) added a task: T101137: Regression: Crash on connecting UV sphere node to transform node.Sep 18 2022, 12:01 PM

Wannes Malfait (Wannes) added a reviewer: Hans Goudey (HooglyBoogly).

Iliya Katueshenock (Moder) awarded a token.Sep 18 2022, 12:19 PM

Eek, thanks for finding this!

This revision is now accepted and ready to land.Sep 18 2022, 5:05 PM

Closed by commit rB8a9f6a2e0a15: Fix T101137: Crash with Transform Node (authored by Wannes Malfait (Wannes), committed by Hans Goudey (HooglyBoogly)). · Explain WhySep 19 2022, 5:59 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB8a9f6a2e0a15: Fix T101137: Crash with Transform Node.

Philipp Oeser (lichtwerk) added a commit: rB9b591a104b35: Fix T101137: Crash with Transform Node.Sep 21 2022, 2:28 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

mesh_runtime.cc

4 lines

Diff 55824

View Options

source/blender/blenkernel/intern/mesh_runtime.cc

Fix T101137: Crash with Transform NodeClosedPublicActions