After rB188f7585a183 deleting the object results in crash due
to null pointer access if collections are filtered out
Details
Details
- Reviewers
Bastien Montagne (mont29) - Maniphest Tasks
- T101233: Regression: Deleting Object in outliner with a specific filter setting crashes Blender.
- Commits
- rB28e09980a2d0: Fix T101233: Crash on deleting the object in outliner due to null pointer access
rB4186b0ebe4e8: Fix T101233: Crash on deleting the object in outliner due to null pointer access
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Besides small style note in comment, LGTM
| source/blender/editors/space_outliner/outliner_tools.cc | ||
|---|---|---|
| 2358 | te_parent != nullptr | |
Comment Actions
eeeeek did not see that was from partial filtered hierarchies in Outliner.... This is actually a fairly sever issue, since it will allow user to unlink things they should not be allowed to, when parent collections are hidden :(((((
Fix is still valid, but it's going to open another issue then
Comment Actions
Hi Bastien, thanks for the review. I've updated the patch.
Fix is still valid, but it's going to open another issue then
Do you want to me commit this or you're expecting any alternative fix?
Comment Actions
@Pratik Borhade (PratikPB2123) there is not much that can be done here, unless we want to do an extensive (and expansive) check on actual data from Main....
This boils down to the extremely bad handling of data hierarchy currently, where outliner builds its own 'view' of the data in Blender, and then operators use this view to actually decide on what they are working... Fixing this is a long term task, so for now your fix is fine yes. Rest will be categorized as 'known issue' for the time being am afraid.