Paths

Table of Contentst

Differential D16038

UV: Add toggle in UV Editor to show the grid over the image.
ClosedPublic
Actions

Authored by Chris Blackbourn (chrisbblend) on Sep 22 2022, 3:22 AM.

Tags

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)

Commits

rBc50335b359e0: UV: add toggle to show the grid over the image

Summary

See also: https://developer.blender.org/T78391

Diff Detail

Repository: rB Blender

Event Timeline

Chris Blackbourn (chrisbblend) requested review of this revision.Sep 22 2022, 3:22 AM

Chris Blackbourn (chrisbblend) created this revision.

Accepting, only minor changes needed.

Also, the patch description should include a short note on why the change is useful, with a reference to T78391.

release/scripts/startup/bl_ui/space_image.py
1535–1540	This could be shown even when there is no image (just greyed out), mainly because it's confusing if docs reference to a setting which the user can't see on-screen.
source/blender/makesrna/intern/rna_space.c
3623	Booleans typically use prefix `use_` or for display options `show_`, `show_grid_over_image` seems fine. Also, would rather keep `use_custom_grid` & `custom_grid_subdivisions` together, this could be moved before/after.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2022, 7:21 AM

Closed by commit rBc50335b359e0: UV: add toggle to show the grid over the image (authored by Chris Blackbourn (chrisbblend)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Chris Blackbourn (chrisbblend) marked 2 inline comments as done.

Chris Blackbourn (chrisbblend) added a commit: rBc50335b359e0: UV: add toggle to show the grid over the image.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

8 lines

source/

blender/

draw/

engines/

overlay/

overlay_grid.cc

3 lines

makesdna/

DNA_space_types.h

2 lines

makesrna/

intern/

6 lines

Diff 55989

release/scripts/startup/bl_ui/space_image.py

Loading...

source/blender/draw/engines/overlay/overlay_grid.cc

Loading...

source/blender/makesdna/DNA_space_types.h

Loading...

source/blender/makesrna/intern/rna_space.c

Loading...