Page MenuHome
Differential D16041

Node Editor: Adjust node link curving
ClosedPublic
Actions

Authored by Leon Schittek (lone_noel) on Sep 22 2022, 3:51 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Pablo Vazquez (pablovazquez)
Commits
rB67308d73a4f9: Node Editor: Adjust node link curving
Summary

Clamp node link curving when the link is close to horizontal.

Issue
Since rBee1d5fb9e467 curved node links always attach to sockets facing
horizontally, entering them from the left and leaving them to the right.
This can look weird, when reroutes are used to route links backwards
horizontally and the ends overshoot.
This type of link routing seems to be commonly used with straight node
links, so it makes sense to support it better with curved links, as
well.

This came up, when discussing T98779 with @Pablo Vazquez (pablovazquez)

Idea
This patch effectively decreases the link curving as the end points get
close to horizontal preventing the overshoot.
A side effect of this is, that the link curving is smoothed out a bit
in general when node links are very horizontal, which I think looks
nicer with very strong link curving anyway.

masterpatch
cuving = 4 (default)
curving = 10 (max)
all curving levels (.gif)

Diff Detail

Repository
rB Blender
Branch
node-ui-adjust-link-curving (branched from master)
Build Status
Buildable 23889
Build 23889: arc lint + arc unit

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.Sep 22 2022, 3:51 PM
Leon Schittek (lone_noel) created this revision.
Harbormaster completed remote builds in B23886: Diff 56006.Sep 22 2022, 3:51 PM
Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)Sep 22 2022, 3:55 PM
Leon Schittek (lone_noel) added projects: Nodes & Physics, Restricted Project.
Hans Goudey (HooglyBoogly) accepted this revision.Sep 22 2022, 5:22 PM
Hans Goudey (HooglyBoogly) added a reviewer: Pablo Vazquez (pablovazquez).
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).

I like the change, it's a nice compromise. Would be good to get Pablo's opinion too though.

source/blender/editors/space_node/drawnode.cc
1613–1614

Could you split this up into two lines with an intermediate variable? There's a lot going on here now which makes it a bit more complex-looking than necessary.

Leon Schittek (lone_noel) updated this revision to Diff 56014.Sep 22 2022, 5:48 PM
Leon Schittek (lone_noel) marked an inline comment as done.
  • Extract variable to improve readability.
Harbormaster completed remote builds in B23889: Diff 56014.Sep 22 2022, 5:48 PM
Pablo Vazquez (pablovazquez) accepted this revision.Sep 23 2022, 12:42 PM

SO much nicer! Thanks for looking into this.

Also props for making such clear demos testing all kinds of ways and different noodle curving.

This revision is now accepted and ready to land.Sep 23 2022, 12:42 PM
João Generoso (juaogeneroso) added a comment.Sep 23 2022, 4:36 PM

It solves the problem perfectly, thank you for your work @Leon Schittek (lone_noel) !

João Generoso (juaogeneroso) awarded a token.Sep 23 2022, 4:36 PM
Closed by commit rB67308d73a4f9: Node Editor: Adjust node link curving (authored by Leon Schittek (lone_noel)). · Explain WhySep 23 2022, 6:14 PM
This revision was automatically updated to reflect the committed changes.
Leon Schittek (lone_noel) added a commit: rB67308d73a4f9: Node Editor: Adjust node link curving.
Ravi Prathama (Endertainer007) awarded a token.Sep 26 2022, 5:47 PM
Vyacheslav (hitrpr) awarded a token.Sep 27 2022, 5:21 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
13 lines

Diff 56014

View Options

source/blender/editors/space_node/drawnode.cc

Loading...