Page MenuHome
Differential D16058

Fix T85978: Add option to use old margin formula for UV Smart Project.
AbandonedPublic
Actions

Authored by Chris Blackbourn (chrisbblend) on Sep 25 2022, 7:59 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T85978: Smart UV island margin value changed since C rewrite

Diff Detail

Repository
rB Blender

Event Timeline

Chris Blackbourn (chrisbblend) requested review of this revision.Sep 25 2022, 7:59 AM
Chris Blackbourn (chrisbblend) created this revision.
Chris Blackbourn (chrisbblend) added a task: T85978: Smart UV island margin value changed since C rewrite.
Chris Blackbourn (chrisbblend) mentioned this in T85978: Smart UV island margin value changed since C rewrite.Sep 25 2022, 8:02 AM
Campbell Barton (campbellbarton) added a comment.Sep 28 2022, 12:32 AM

Is there any reason this needs to be an option? why not make it default behavior?

Campbell Barton (campbellbarton) added a comment.Sep 28 2022, 12:23 PM

Unless the current method seems particularly useful, I think we could move to back to the 2.8x method.

If we keep both options, currently there is no indication what the 2.8 margin calculation is... and what happens when it's off.
So if we have two methods, then it's probably best to use an enum, with a name & description for each.

Chris Blackbourn (chrisbblend) abandoned this revision.Oct 1 2022, 7:12 AM

Replaced by https://developer.blender.org/D16121

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
2 lines
uvedit/
23 lines
8 lines

Diff 56092

View Options

source/blender/editors/include/ED_uvedit.h

Loading...
View Options

source/blender/editors/uvedit/uvedit_islands.cc

Loading...
View Options

source/blender/editors/uvedit/uvedit_unwrap_ops.c

Loading...