Page MenuHome

Fix T101361: Check if node is hidden
ClosedPublic

Authored by Iliya Katueshenock (Moder) on Sep 25 2022, 4:55 PM.

Details

Diff Detail

Event Timeline

This does fix the issue, thanks!

I did leave a nitpicky inline comment, but let's wait for Hans' opinion on whether that's actually better.

source/blender/editors/space_node/drawnode.cc
1591–1592

I think using the socket.is_multi_input() and socket.is_input() methods would make this more readable (and make it fit into one line ;) ).

We could get the node via socket.owner_node() rather than link->tonode. It seems nice to have all the checks here depend on the socket. Though I'm not sure if there are situations, where the node tree's topology cache could be an issue.

Agreed with @Leon Schittek (lone_noel)'s comments here. Otherwise, thanks for making the patch!

Iliya Katueshenock (Moder) planned changes to this revision.Sep 26 2022, 7:20 PM

Then I'll update now.

Lucky and the formatting actually kept it on one line

This revision is now accepted and ready to land.Sep 26 2022, 11:57 PM