Page MenuHome

Cleanup: remove workarounds and version checks for unsupported compilers
ClosedPublic

Authored by Campbell Barton (campbellbarton) on Sep 26 2022, 5:25 AM.

Details

Summary

Remove checks & workarounds for unsupported compilers.

Match minimum supported versions from the WIKI [0] by raising them to:

  • GCC 9.3.1
  • CLANG 8.0
  • MVCS 2019 (16.9.16 / 1928)

Details:

  • Add CMake checks that ensure supported compiler versions early on.
  • Previously GCC per-processor version checks served to exclude __clang__, in some cases this has been replaced by explicitly excluding __clang__. This was needed as CLANG treated some of these flags differently to GCC, causing the build to fail.
  • Remove USE_APPLE_OMP_FIX GCC-4.2 OpenMP workaround.
  • Remove linking error workaround for old MSVC versions.

[0]: https://wiki.blender.org/wiki/Building_Blender


Diff Detail

Repository
rB Blender
Branch
TEMP-REMOVE-OLD-COMPILER-COMPAT (branched from master)
Build Status
Buildable 23947
Build 23947: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Sep 26 2022, 5:25 AM
Campbell Barton (campbellbarton) created this revision.
  • Correct comment wording that no longer made sense.
  • Fix building with clang by disabling strict GCC warnings with clang.
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 26 2022, 10:38 PM
  • Add comment for why strict warnings errors cannot use clang