Page MenuHome

Fix T101492: UV stitch crash (more than 32 objects selected)
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Sep 30 2022, 1:48 PM.

Details

Summary

Crash happened when adjusting operator props in Adjust Last Operation
panel.

When there are more than 32 objects selected in muti-object-editmode, we
are running into RNA array limit (objects_selection_count is defined as
an RNA array (which can only hold 32 entries, see
RNA_MAX_ARRAY_LENGTH), leading to reading random memory errors.

While there might be ways to make this work with more than 32 selected
objects, this patch only cancels the operator with a report message
(instead of crashing).

Diff Detail

Repository
rB Blender
Branch
T101492 (branched from master)
Build Status
Buildable 24043
Build 24043: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 30 2022, 1:48 PM
Philipp Oeser (lichtwerk) created this revision.
Philipp Oeser (lichtwerk) added projects: Modeling, Restricted Project.Sep 30 2022, 1:49 PM

Accepting as it's better than crashing, but I it might make sense to use a collection instead of an array. Or investigate supporting dynamic sized arrays for run-time RNA (as this should map to ID property arrays neatly).

This revision is now accepted and ready to land.Oct 6 2022, 1:47 PM