Page MenuHome

deps_builder: harden the package download process
ClosedPublic

Authored by Ray Molenkamp (LazyDodo) on Oct 1 2022, 9:06 PM.

Details

Summary

During the 3.3 release some packages were missing
in SVN during the release and it ended up building
the release tarball without issues when re-running
the make source_archive_complete after it failed
initially. The tarball however had 0 byte files
for the missing packages.... not good.

This diff hardens the download process by

  1. Validating all variables are set, this catches

the erroneously attempt at downloading the
nanovdb package even though we have removed it
from versions.cmake but neglected to remove it
from download.cmake

  1. When a download fails (due to either a missing

package, or bad download URL) FILE Download will
warn about a hash mismatch but will carry on
happily, you then have to go into the file system
go delete the 0 byte file, to retry the download.
We know for a fact the file is bad, just delete it.

  1. When we are using the blender repository

explicitly validate the hash of all packages.
Normally the build process does this, however
when building a source archive the build does
not actually run for a dep. So preform this
check during the configuration stage

Diff Detail

Repository
rB Blender
Branch
tmp_dep_download_hardening (branched from master)
Build Status
Buildable 24062
Build 24062: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Oct 1 2022, 9:06 PM
Ray Molenkamp (LazyDodo) created this revision.
Brecht Van Lommel (brecht) added inline comments.
build_files/build_environment/cmake/download.cmake
20

>${TARGET_FILE}< can be left out since it will be empty and not print anything useful.

This revision is now accepted and ready to land.Oct 2 2022, 8:35 PM